refactor: [database/client] dbflow to room #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-dbflow-to-room # Conflicts: # core/data/src/main/java/com/mifos/core/data/repository/ClientIdentifiersRepository.kt # core/data/src/main/java/com/mifos/core/data/repository/CreateNewClientRepository.kt # core/data/src/main/java/com/mifos/core/data/repositoryImp/ClientIdentifiersRepositoryImp.kt # core/data/src/main/java/com/mifos/core/data/repositoryImp/CreateNewClientRepositoryImp.kt # core/database/src/main/java/com/mifos/room/dao/ClientDao.kt # core/database/src/main/java/com/mifos/room/db/MifosDatabase.kt # core/database/src/main/java/com/mifos/room/di/DaoModule.kt # core/database/src/main/java/com/mifos/room/entities/client/Savings.kt
* [database.group] dbflow to room * fix checks
* MIFOSAC-342 [database.center] dbFlow to room migration
* feat(office): migrated Dbflow to Room * fix: data type and removed Gson * fix: model usage in useCase * refactor: replaced entity instead of model * fix: spotless error * fix checks failure --------- Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
* MIFOSAC-392 [database/charge] dbflow to room * backup * Fix exception * added singleton
# Conflicts: # core/data/src/main/java/com/mifos/core/data/pagingSource/ClientChargesPagingSource.kt # core/data/src/main/java/com/mifos/core/data/repository/CreateNewClientRepository.kt # core/data/src/main/java/com/mifos/core/data/repositoryImp/CreateNewClientRepositoryImp.kt # core/database/src/main/java/com/mifos/room/db/MifosDatabase.kt # core/database/src/main/java/com/mifos/room/entities/accounts/savings/SavingsAccount.kt
…droid-client into client-dbflow-to-room
niyajali
requested changes
Mar 1, 2025
Collaborator
niyajali
left a comment
There was a problem hiding this comment.
Do this changes or if you planning to fix in other PR, let us know we will proceed with Merge.
core/data/src/main/java/com/mifos/core/data/repository/ClientDetailsRepository.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/repositoryImp/ClientDetailsRepositoryImp.kt
Outdated
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/core/databasehelper/DatabaseHelperClient.kt
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/room/helper/ClientDaoHelper.kt
Outdated
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/room/helper/ClientDaoHelper.kt
Outdated
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/room/helper/ClientDaoHelper.kt
Outdated
Show resolved
Hide resolved
core/model/src/commonMain/kotlin/com/mifos/core/model/objects/clients/Address.kt
Outdated
Show resolved
Hide resolved
Contributor
|
@itsPronay Thanks for improving on my initial work. I'm still learning Android and Kotlin, so this is helpful for me to see. |
niyajali
approved these changes
Mar 5, 2025
Collaborator
|
@itsPronay Should we proceed with merge |
2 tasks
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core:database): remove columninfo annotaions from room:entities:templates * refactor(core:database): replace HashMap with emptyMap * refactor(core): restore original files DataManagerClient and ActivatePayload * refactor(core:data): migrate dbflow to room * refactor(core:database): update ClientDao * refactor(core): update ClientDao and other files in :core:data and :core:database * refactor: [database.group] dbflow to room (openMF#2313) * [database.group] dbflow to room * fix checks * refactor: [database.center] dbFlow to room migration (openMF#2307) * MIFOSAC-342 [database.center] dbFlow to room migration * refactor: [database.office] dbflow to room (openMF#2314) * feat(office): migrated Dbflow to Room * fix: data type and removed Gson * fix: model usage in useCase * refactor: replaced entity instead of model * fix: spotless error * fix checks failure --------- Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com> * refactor: [database/charge] dbflow to room (openMF#2312) * MIFOSAC-392 [database/charge] dbflow to room * backup * Fix exception * added singleton * refactor(core:database): update ClientDaoHelper and ClientAccounts * refactor(core:database): update ClientDaoHelper and ClientTypeConverters * refactor(core:database): update DAO classes and clean up comments * [database/client] dbflow to room * fix * made changes --------- Co-authored-by: Biplab Dutta <biplabdutta27@gmail.com> Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core:database): remove columninfo annotaions from room:entities:templates * refactor(core:database): replace HashMap with emptyMap * refactor(core): restore original files DataManagerClient and ActivatePayload * refactor(core:data): migrate dbflow to room * refactor(core:database): update ClientDao * refactor(core): update ClientDao and other files in :core:data and :core:database * refactor: [database.group] dbflow to room (openMF#2313) * [database.group] dbflow to room * fix checks * refactor: [database.center] dbFlow to room migration (openMF#2307) * MIFOSAC-342 [database.center] dbFlow to room migration * refactor: [database.office] dbflow to room (openMF#2314) * feat(office): migrated Dbflow to Room * fix: data type and removed Gson * fix: model usage in useCase * refactor: replaced entity instead of model * fix: spotless error * fix checks failure --------- Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com> * refactor: [database/charge] dbflow to room (openMF#2312) * MIFOSAC-392 [database/charge] dbflow to room * backup * Fix exception * added singleton * refactor(core:database): update ClientDaoHelper and ClientAccounts * refactor(core:database): update ClientDaoHelper and ClientTypeConverters * refactor(core:database): update DAO classes and clean up comments * [database/client] dbflow to room * fix * made changes --------- Co-authored-by: Biplab Dutta <biplabdutta27@gmail.com> Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-341
This pull request presents an improved version of #2300 by @biplab1 , addressing several issues identified in the original submission