refactor: [database.center] dbFlow to room migration #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyajali
requested changes
Feb 12, 2025
Collaborator
niyajali
left a comment
There was a problem hiding this comment.
@itsPronay do this changes fix spotless, and removed all commented code block and let us know we'll merge this PR
core/database/src/main/java/com/mifos/room/entities/accounts/CenterAccounts.kt
Outdated
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/room/entities/accounts/savings/DepositType.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/repository/SyncCentersDialogRepository.kt
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/repositoryImp/SyncCentersDialogRepositoryImp.kt
Outdated
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/services/CenterService.kt
Show resolved
Hide resolved
core/network/src/main/java/com/mifos/core/network/services/CenterService.kt
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/repository/CreateNewCenterRepository.kt
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/repository/OfflineDashboardRepository.kt
Outdated
Show resolved
Hide resolved
core/data/src/main/java/com/mifos/core/data/repository/SyncCenterPayloadsRepository.kt
Show resolved
Hide resolved
HekmatullahAmin
suggested changes
Feb 13, 2025
core/database/src/main/java/com/mifos/room/entities/accounts/savings/DepositType.kt
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/room/entities/accounts/savings/SavingsAccount.kt
Show resolved
Hide resolved
core/database/src/main/java/com/mifos/room/entities/accounts/savings/Status.kt
Show resolved
Hide resolved
niyajali
requested changes
Feb 13, 2025
...enter/src/main/java/com/mifos/feature/center/syncCentersDialog/SyncCentersDialogViewModel.kt
Outdated
Show resolved
Hide resolved
niyajali
requested changes
Feb 15, 2025
Collaborator
niyajali
left a comment
There was a problem hiding this comment.
Do these changes and let me know we'll merge this PR..
core/database/src/main/java/com/mifos/room/entities/accounts/savings/SavingsAccount.kt
Show resolved
Hide resolved
niyajali
approved these changes
Feb 17, 2025
biplab1
pushed a commit
to biplab1/android-client
that referenced
this pull request
Feb 20, 2025
* MIFOSAC-342 [database.center] dbFlow to room migration
therajanmaurya
pushed a commit
that referenced
this pull request
Mar 6, 2025
* refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core:database): remove columninfo annotaions from room:entities:templates * refactor(core:database): replace HashMap with emptyMap * refactor(core): restore original files DataManagerClient and ActivatePayload * refactor(core:data): migrate dbflow to room * refactor(core:database): update ClientDao * refactor(core): update ClientDao and other files in :core:data and :core:database * refactor: [database.group] dbflow to room (#2313) * [database.group] dbflow to room * fix checks * refactor: [database.center] dbFlow to room migration (#2307) * MIFOSAC-342 [database.center] dbFlow to room migration * refactor: [database.office] dbflow to room (#2314) * feat(office): migrated Dbflow to Room * fix: data type and removed Gson * fix: model usage in useCase * refactor: replaced entity instead of model * fix: spotless error * fix checks failure --------- Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com> * refactor: [database/charge] dbflow to room (#2312) * MIFOSAC-392 [database/charge] dbflow to room * backup * Fix exception * added singleton * refactor(core:database): update ClientDaoHelper and ClientAccounts * refactor(core:database): update ClientDaoHelper and ClientTypeConverters * refactor(core:database): update DAO classes and clean up comments * [database/client] dbflow to room * fix * made changes --------- Co-authored-by: Biplab Dutta <biplabdutta27@gmail.com> Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* MIFOSAC-342 [database.center] dbFlow to room migration
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core:database): remove columninfo annotaions from room:entities:templates * refactor(core:database): replace HashMap with emptyMap * refactor(core): restore original files DataManagerClient and ActivatePayload * refactor(core:data): migrate dbflow to room * refactor(core:database): update ClientDao * refactor(core): update ClientDao and other files in :core:data and :core:database * refactor: [database.group] dbflow to room (openMF#2313) * [database.group] dbflow to room * fix checks * refactor: [database.center] dbFlow to room migration (openMF#2307) * MIFOSAC-342 [database.center] dbFlow to room migration * refactor: [database.office] dbflow to room (openMF#2314) * feat(office): migrated Dbflow to Room * fix: data type and removed Gson * fix: model usage in useCase * refactor: replaced entity instead of model * fix: spotless error * fix checks failure --------- Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com> * refactor: [database/charge] dbflow to room (openMF#2312) * MIFOSAC-392 [database/charge] dbflow to room * backup * Fix exception * added singleton * refactor(core:database): update ClientDaoHelper and ClientAccounts * refactor(core:database): update ClientDaoHelper and ClientTypeConverters * refactor(core:database): update DAO classes and clean up comments * [database/client] dbflow to room * fix * made changes --------- Co-authored-by: Biplab Dutta <biplabdutta27@gmail.com> Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* MIFOSAC-342 [database.center] dbFlow to room migration
itsPronay
added a commit
to itsPronay/android-client
that referenced
this pull request
Aug 5, 2025
* refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core): migrate from dbflow to room in core:data and core:database * refactor(core): replace var with val in core:database * refactor(core): replace var with val in core:database and delete some files * refactor(core): update files after ci-prepush * refactor(core:database): remove columninfo annotations from room entities * chore: apply ci-prepush changes * refactor: correct import statements for client room entities * chore: update ci-prepush changes * feat(core:database): Update ClientDao * refactor(core:database): remove columninfo annotaions from room:entities:templates * refactor(core:database): replace HashMap with emptyMap * refactor(core): restore original files DataManagerClient and ActivatePayload * refactor(core:data): migrate dbflow to room * refactor(core:database): update ClientDao * refactor(core): update ClientDao and other files in :core:data and :core:database * refactor: [database.group] dbflow to room (openMF#2313) * [database.group] dbflow to room * fix checks * refactor: [database.center] dbFlow to room migration (openMF#2307) * MIFOSAC-342 [database.center] dbFlow to room migration * refactor: [database.office] dbflow to room (openMF#2314) * feat(office): migrated Dbflow to Room * fix: data type and removed Gson * fix: model usage in useCase * refactor: replaced entity instead of model * fix: spotless error * fix checks failure --------- Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com> * refactor: [database/charge] dbflow to room (openMF#2312) * MIFOSAC-392 [database/charge] dbflow to room * backup * Fix exception * added singleton * refactor(core:database): update ClientDaoHelper and ClientAccounts * refactor(core:database): update ClientDaoHelper and ClientTypeConverters * refactor(core:database): update DAO classes and clean up comments * [database/client] dbflow to room * fix * made changes --------- Co-authored-by: Biplab Dutta <biplabdutta27@gmail.com> Co-authored-by: Nagarjuna <nagarjunabanda4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-342
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.