Add normative language for metrics API/SDK concurrency#4868
Add normative language for metrics API/SDK concurrency#4868reyang merged 5 commits intoopen-telemetry:mainfrom
Conversation
|
@open-telemetry/spec-sponsors @open-telemetry/specs-metrics-approvers |
There was a problem hiding this comment.
Please see #4867 (comment)
It is a meaningless statement to recommend that a stateless API is concurrent safe.
No consensus of that issue has been reached and this PR is inappropriate.
trask
left a comment
There was a problem hiding this comment.
It is a meaningless statement to recommend that a stateless API is concurrent safe.
I'm probably missing some part of your argument here (I've read the issue too), because I think it's very common in general for APIs to put requirements on their implementations.
Happy to clarify any misunderstanding about my comment in the issue in the issue. 👍 |
Similar to #4868. ## Changes Please provide a brief description of the changes here. For non-trivial changes, follow the [change proposal process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change). * [x] Related issues #4867 * [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) # * [ ] Links to the prototypes (when adding or changing features) * [x] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes * For trivial changes, include `[chore]` in the PR title to skip the changelog check * [ ] [Spec compliance matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix/template.yaml) updated if necessary
### Context - Deprecate Jaeger propagator and make propagator implementation optional. ([#4827](#4827)) - Deprecate OT Trace propagator and make propagator implementation optional. ([#4851](#4851)) ### Metrics - Add normative language to the Metrics API/SDK spec concurrency requirements. ([#4868](#4868)) ### Logs - Add optional `Exception` parameter to Emit LogRecord. ([#4824](#4824)) - Add normative language to the Logging API/SDK spec concurrency requirements. ([#4885](#4885)) ### Resource - Refine the handling of OTEL_RESOURCE_ATTRIBUTES. ([#4856](#4856)) ### Common - Add string representation guidance for complex attribute value types (byte arrays, empty values, arrays, and maps) for non-OTLP protocols. ([#4848](#4848)) ### Compatibility - Stabilize Prometheus Counter to OTLP Sum transformation. ([#4862](#4862)) - Stabilize Prometheus Gauge to OTLP Gauge transformation. ([#4871](#4871)) ### SDK Configuration - Swap Tracer/Meter/LoggerConfig `disabled` for `enabled` to avoid double negatives ([#4823](#4823)) - Declarative configuration: rename `ComponentProvider` to `PluginComponentProvider`, `CreatePlugin` to `CreateComponent` in effort to use consistent vocabulary ([#4806](#4806)) - Declarative configuration: Update instrumentation config behavior to return empty object when not set ([#4817](#4817))
…led concurrently (#7952) Fixes #7864 Follows this spec change: open-telemetry/opentelemetry-specification#4868 --------- Co-authored-by: Robert Pająk <pellared@hotmail.com>
Similar to #4868. ## Changes Please provide a brief description of the changes here. For non-trivial changes, follow the [change proposal process](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CONTRIBUTING.md#proposing-a-change). * [x] Related issues #4867 * [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) # * [ ] Links to the prototypes (when adding or changing features) * [x] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes * For trivial changes, include `[chore]` in the PR title to skip the changelog check * [ ] [Spec compliance matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix/template.yaml) updated if necessary
Fixes #4867
Changes
Please provide a brief description of the changes here.
For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changes[chore]in the PR title to skip the changelog check