Skip to content

Swap Tracer/Meter/LoggerConfig disabled for enabled to avoid double negatives#4823

Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom
trask:config-enabled
Jan 9, 2026
Merged

Swap Tracer/Meter/LoggerConfig disabled for enabled to avoid double negatives#4823
lmolkova merged 2 commits intoopen-telemetry:mainfrom
trask:config-enabled

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Jan 7, 2026

(this change has been unblocked by #4723)

This will help avoid double negatives (disabled: false) in declarative configuration, e.g.

instead of ExperimentalTracerConfigurator_kitchen_sink.yaml:

tracer_provider:
  tracer_configurator/development:
    default_config:
      disabled: true
    tracers:
      - name: io.opentelemetry.contrib.*
        config:
          disabled: false

if this PR is accepted, we would change this to:

tracer_provider:
  tracer_configurator/development:
    default_config:
      enabled: false
    tracers:
      - name: io.opentelemetry.contrib.*
        config:
          enabled: true

FWIW, this matches similar existing usage of enabled (over disabled) in the Java agent:

  • otel.instrumentation.common.default-enabled
  • otel.instrumentation.<name>.enabled

@trask trask marked this pull request as ready for review January 7, 2026 17:45
@trask trask requested review from a team as code owners January 7, 2026 17:45
Copy link
Copy Markdown
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lmolkova lmolkova added this pull request to the merge queue Jan 9, 2026
Merged via the queue into open-telemetry:main with commit fbe98fe Jan 9, 2026
8 checks passed
@lmolkova lmolkova deleted the config-enabled branch January 9, 2026 18:42
@carlosalberto carlosalberto mentioned this pull request Feb 11, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 13, 2026
### Context

- Deprecate Jaeger propagator and make propagator implementation
optional.

([#4827](#4827))
- Deprecate OT Trace propagator and make propagator implementation
optional.

([#4851](#4851))

### Metrics

- Add normative language to the Metrics API/SDK spec concurrency
requirements.

([#4868](#4868))

### Logs

- Add optional `Exception` parameter to Emit LogRecord.

([#4824](#4824))
- Add normative language to the Logging API/SDK spec concurrency
requirements.

([#4885](#4885))

### Resource

- Refine the handling of OTEL_RESOURCE_ATTRIBUTES.

([#4856](#4856))

### Common

- Add string representation guidance for complex attribute value types
(byte arrays,
  empty values, arrays, and maps) for non-OTLP protocols.

([#4848](#4848))

### Compatibility

- Stabilize Prometheus Counter to OTLP Sum transformation.

([#4862](#4862))
- Stabilize Prometheus Gauge to OTLP Gauge transformation.

([#4871](#4871))

### SDK Configuration

- Swap Tracer/Meter/LoggerConfig `disabled` for `enabled` to avoid
double negatives

([#4823](#4823))
- Declarative configuration: rename `ComponentProvider` to
`PluginComponentProvider`, `CreatePlugin` to `CreateComponent` in effort
to
  use consistent vocabulary

([#4806](#4806))
- Declarative configuration: Update instrumentation config behavior to
return
  empty object when not set

([#4817](#4817))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants