Skip to content

Move experimental sampling specification into OTEPs#4673

Merged
jmacd merged 12 commits intoopen-telemetry:mainfrom
jmacd:jmacd/deprecate_experimental_sampler
Oct 10, 2025
Merged

Move experimental sampling specification into OTEPs#4673
jmacd merged 12 commits intoopen-telemetry:mainfrom
jmacd:jmacd/deprecate_experimental_sampler

Conversation

@jmacd
Copy link
Copy Markdown
Contributor

@jmacd jmacd commented Oct 1, 2025

Goal is to improve our public documentation, which has two documents with the same title today, the second one being correct.

Finishes the deprecation process started in #4168.
When #4166 added the new sampling specification, the old one was renamed.
Now that the new specification is complete in the specification, the old one is a distraction.

Changes

This moves the old document into the oteps/ repository where it will remain a permanent record of this effort.

@jmacd
Copy link
Copy Markdown
Contributor Author

jmacd commented Oct 2, 2025

@PeterF778 FYI

@jmacd jmacd marked this pull request as ready for review October 2, 2025 17:22
@jmacd jmacd requested review from a team as code owners October 2, 2025 17:22
@carlosalberto
Copy link
Copy Markdown
Contributor

LGTM although not sure using the PR number feels good as this is a "old reference" document, rather than an actual OTEP.

@jmacd jmacd added this pull request to the merge queue Oct 10, 2025
Merged via the queue into open-telemetry:main with commit f2db30d Oct 10, 2025
7 checks passed
@jmacd jmacd deleted the jmacd/deprecate_experimental_sampler branch October 10, 2025 16:12
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmacd et all: thanks for the cleanup. Note that if you remove a page from the spec, you need to add a redirect rule, otherwise website users will get a 404, as shows up from the link-check failure in https://github.com/open-telemetry/opentelemetry.io/actions/runs/18428326656/job/52512470938?pr=7872.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosalberto carlosalberto mentioned this pull request Oct 15, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2025
### Traces

- Restore `TraceIdRatioBased` and give it a deprecation timeline. Update
recommended
warnings based on feedback in issue
[#4601](#4601).

([#4627](#4627))
- Changes of `TracerConfig.disabled` MUST be eventually visible.

([#4645](#4645))
- Remove text related to the former expermental probability sampling
specification.

([#4673](#4673))

### Metrics

- Changes of `MeterConfig.disabled` MUST be eventually visible.

([#4645](#4645))

### Logs

- Add minimum_severity and trace_based logger configuration parameters.

([#4612](#4612))
- Changes of `LoggerConfig.disabled` MUST be eventually visible.

([#4645](#4645))

---------

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants