Skip to content

TraceIdRatioBased deprecation plan, "ProbabilitySampler"#4627

Merged
carlosalberto merged 16 commits intoopen-telemetry:mainfrom
jmacd:jmacd/otep235migrate
Sep 30, 2025
Merged

TraceIdRatioBased deprecation plan, "ProbabilitySampler"#4627
carlosalberto merged 16 commits intoopen-telemetry:mainfrom
jmacd:jmacd/otep235migrate

Conversation

@jmacd
Copy link
Contributor

@jmacd jmacd commented Aug 14, 2025

Part of #1413
Fixes #4601

Changes

Restores TraceIdRatioBased specification from before #4166.

@jmacd jmacd requested review from a team August 14, 2025 16:48
Co-authored-by: Otmar Ertl <otmar.ertl@gmail.com>
@jmacd jmacd requested review from a team as code owners August 28, 2025 15:31
@jmacd
Copy link
Contributor Author

jmacd commented Aug 28, 2025

I eliminated any specification about the description. I agree with this approach @trask, especially considering the primary concern of this effort is to label every sampled span with a probability!

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@carlosalberto
Copy link
Contributor

A few details to resolve but overall LGTM.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 20, 2025
@jmacd jmacd removed the Stale label Sep 22, 2025
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 30, 2025
@carlosalberto carlosalberto added this pull request to the merge queue Sep 30, 2025
Merged via the queue into open-telemetry:main with commit ec3779c Sep 30, 2025
7 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Oct 3, 2025
…nce (#4674)

## Changes

When reading through #4627, I noticed that the Probability Sampler
description still had a reference to ratio-based. I think that entire
section may be cut since the clarifications were specifically related to
the old name.

Also, found a small typo.

This seems like a trivial change, so I did not create a new issue nor
add a CHANGELOG.md entry. Please let me know if you would rather I make
one.

* [ ] Related issues: PR #4627
* [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) N/A
* [ ] Links to the prototypes (when adding or changing features) N/A
* [ ]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes N/A
* [ ] [Spec compliance
matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix/template.yaml)
updated if necessary N/A
@carlosalberto carlosalberto mentioned this pull request Oct 10, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 17, 2025
### Traces

- Restore `TraceIdRatioBased` and give it a deprecation timeline. Update
recommended
warnings based on feedback in issue
[#4601](#4601).

([#4627](#4627))
- Changes of `TracerConfig.disabled` MUST be eventually visible.

([#4645](#4645))
- Remove text related to the former expermental probability sampling
specification.

([#4673](#4673))

### Metrics

- Changes of `MeterConfig.disabled` MUST be eventually visible.

([#4645](#4645))

### Logs

- Add minimum_severity and trace_based logger configuration parameters.

([#4612](#4612))
- Changes of `LoggerConfig.disabled` MUST be eventually visible.

([#4645](#4645))

---------

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation process for TraceIdRatioBased sampler

6 participants