TraceIdRatioBased deprecation plan, "ProbabilitySampler"#4627
Merged
carlosalberto merged 16 commits intoopen-telemetry:mainfrom Sep 30, 2025
Merged
TraceIdRatioBased deprecation plan, "ProbabilitySampler"#4627carlosalberto merged 16 commits intoopen-telemetry:mainfrom
carlosalberto merged 16 commits intoopen-telemetry:mainfrom
Conversation
…phase-in new behavior
jmacd
commented
Aug 14, 2025
jmacd
commented
Aug 14, 2025
jmacd
commented
Aug 14, 2025
5 tasks
trask
reviewed
Aug 19, 2025
oertl
reviewed
Aug 25, 2025
Co-authored-by: Otmar Ertl <otmar.ertl@gmail.com>
Co-authored-by: Otmar Ertl <otmar.ertl@gmail.com>
…ication into jmacd/otep235migrate
…-specification into jmacd/otep235migrate
…ication into jmacd/otep235migrate
Contributor
Author
|
I eliminated any specification about the description. I agree with this approach @trask, especially considering the primary concern of this effort is to label every sampled span with a probability! |
trask
reviewed
Aug 28, 2025
trask
reviewed
Aug 28, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
approved these changes
Sep 12, 2025
Contributor
|
A few details to resolve but overall LGTM. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
…ication into jmacd/otep235migrate
trask
approved these changes
Sep 22, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
lmolkova
approved these changes
Sep 30, 2025
jsuereth
approved these changes
Sep 30, 2025
5 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 3, 2025
…nce (#4674) ## Changes When reading through #4627, I noticed that the Probability Sampler description still had a reference to ratio-based. I think that entire section may be cut since the clarifications were specifically related to the old name. Also, found a small typo. This seems like a trivial change, so I did not create a new issue nor add a CHANGELOG.md entry. Please let me know if you would rather I make one. * [ ] Related issues: PR #4627 * [ ] Related [OTEP(s)](https://github.com/open-telemetry/oteps) N/A * [ ] Links to the prototypes (when adding or changing features) N/A * [ ] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes N/A * [ ] [Spec compliance matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix/template.yaml) updated if necessary N/A
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 17, 2025
### Traces - Restore `TraceIdRatioBased` and give it a deprecation timeline. Update recommended warnings based on feedback in issue [#4601](#4601). ([#4627](#4627)) - Changes of `TracerConfig.disabled` MUST be eventually visible. ([#4645](#4645)) - Remove text related to the former expermental probability sampling specification. ([#4673](#4673)) ### Metrics - Changes of `MeterConfig.disabled` MUST be eventually visible. ([#4645](#4645)) ### Logs - Add minimum_severity and trace_based logger configuration parameters. ([#4612](#4612)) - Changes of `LoggerConfig.disabled` MUST be eventually visible. ([#4645](#4645)) --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1413
Fixes #4601
Changes
Restores TraceIdRatioBased specification from before #4166.
CHANGELOG.mdfile updated for non-trivial changes