[spec] [entities] Mention entity references in the stability guarantees#4593
Merged
reyang merged 2 commits intoopen-telemetry:mainfrom Aug 6, 2025
Merged
Conversation
Given that type of an entity is a part of it's identity, we should define stability guarantees for that given that identifying attributes already covered by the guarantees for the resource attributes.
jsuereth
approved these changes
Jul 17, 2025
lmolkova
approved these changes
Jul 18, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Contributor
|
@jsuereth Would you like to get anybody else to review this, or we merge it? |
dyladan
approved these changes
Jul 29, 2025
Member
dyladan
left a comment
There was a problem hiding this comment.
LGTM
aside: the section this is in says "Semantic Conventions defines the set of fields in the OTLP data model." Should this say "Semantic Conventions defines the set of stable fields in the OTLP data model?" (added word stable). SemConv also defines other things, they're just not guaranteed stability (attr value for example).
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Member
|
I think this can be merged? |
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 13, 2025
August 2025 release. ### Logs - Improve concurrency safety description of `LogRecordProcessor.OnEmit`. ([#4578](#4578)) - Clarify that `SeverityNumber` values are used when comparing severities. ([#4552](#4552)) ### Entities - Mention entity references in the stability guarantees. ([#4593](#4593)) ### OpenTelemetry Protocol - Clarify protocol defaults on specification. ([#4585](#4585)) ### Compatibility - Flexibilie escaping of characters that are discouraged by Prometheus Conventions in Prometheus exporters. ([#4533](#4533)) - Flexibilize addition of unit/type related suffixes in Prometheus exporters. ([#4533](#4533)) - Define the configuration option "Translation Strategies" for Prometheus exporters. ([#4533](#4533)) - Define conversion of Prometheus native histograms to OpenTelemetry exponential histograms. ([#4561](#4561)) - Clarify what to do when scope attribute conflicts with name, version and schema URL. ([#4599](#4599)) ### SDK Configuration - Enum values provided via environment variables SHOULD be interpreted in a case-insensitive manner. ([#4576](#4576)) Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since an entity’s type is part of its identity, we should define stability guarantees for it, considering that the identifying attributes are already covered by resource attribute guarantees.
Fixes #4451