Clarify log record severity comparison#4552
Clarify log record severity comparison#4552carlosalberto merged 13 commits intoopen-telemetry:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
This applied suggestion makes this PR blocked by: |
|
SIG meeting notes: |
I feel that this PR does not contradict with the proposal to allow only 0..24 when exporting via OTLP. |
|
Logs SIG meeting: We also agreed that, due to the current state of Logs language implementations and the OTLP proto definition, we can only RECOMMEND using values between 0 and 24. |
|
SIG meeting notes: |
|
@tigrannajaryan Merging this, FYI |
August 2025 release. ### Logs - Improve concurrency safety description of `LogRecordProcessor.OnEmit`. ([#4578](#4578)) - Clarify that `SeverityNumber` values are used when comparing severities. ([#4552](#4552)) ### Entities - Mention entity references in the stability guarantees. ([#4593](#4593)) ### OpenTelemetry Protocol - Clarify protocol defaults on specification. ([#4585](#4585)) ### Compatibility - Flexibilie escaping of characters that are discouraged by Prometheus Conventions in Prometheus exporters. ([#4533](#4533)) - Flexibilize addition of unit/type related suffixes in Prometheus exporters. ([#4533](#4533)) - Define the configuration option "Translation Strategies" for Prometheus exporters. ([#4533](#4533)) - Define conversion of Prometheus native histograms to OpenTelemetry exponential histograms. ([#4561](#4561)) - Clarify what to do when scope attribute conflicts with name, version and schema URL. ([#4599](#4599)) ### SDK Configuration - Enum values provided via environment variables SHOULD be interpreted in a case-insensitive manner. ([#4576](#4576)) Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Follows:
SeverityNumber=0MAY be used to represent an unspecified value #4535Why
Related to #4540
Supersedes #4541 per #4541 (comment) and discussions from the last OTel Specification and Logs SIG meetings.
Some comments that were already expressed as comments.
From #4541 (comment):
From #4541 (comment):
This is also inline with
opentelemetry-specification/specification/logs/data-model.md
Lines 323 to 329 in 7e7c0bd
From #4540 (comment):
We agreed that this PR does conflict proposal to allow only allow/support 0..24 SeverityNumber values.
What
Removal of
as I find that this sentence is more confusing than clarifying:
SeverityNumberthat are greater than 24 or lesser than 1?Removal of duplicated description
Moving the comparison example to a better place where the
SeverityNumbercomparison is describedSimplify
SeverityProcessorexample.Prototype
This is exactly how https://pkg.go.dev/go.opentelemetry.io/contrib/processors/minsev currently works.