[entities] Define rules for entity-resource referencing model#4499
Conversation
fb0a302 to
5b74b75
Compare
jsuereth
left a comment
There was a problem hiding this comment.
On board with the normative portions of this.
Have suggestions for how to rework the specification wording so this is about the data-model, and flexible enough to support future evolution.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
8cdc84a to
1359107
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
1359107 to
f8a4a6d
Compare
tigrannajaryan
left a comment
There was a problem hiding this comment.
Mostly LGTM, just one comment remaining about a term used ("most specific").
Adds description of how entities reference resource attributes and clarifies rules for handling shared descriptive attributes across entities.
f8a4a6d to
a022920
Compare
| If multiple entities share the same descriptive attribute key with potentially | ||
| conflicting values, the attribute MUST logically belong to **only one** of them. | ||
| All others SHOULD NOT reference it. The attribute MUST be referenced by the | ||
| **most specific** entity, the one closest in the topology graph to the entity |
There was a problem hiding this comment.
I don't understand what "closest in the topology graph" means. The confusing example is not k8s.node and k8s.cluster, it's k8s.node and gce.instance, where the resources come from two different topologies.
There was a problem hiding this comment.
What shared attributes k8s.node and gce.instance would have? I cannot think of any
### Metrics - Prometheus receiver can expect `otel_scope_schema_url` and `otel_scope_[attribute]` labels on all metrics. ([#4505](#4505)) - Prometheus receiver no longer expects `otel_scope_info` metric. ([#4505](#4505)) - Prometheus exporter adds `otel_scope_schema_url` and `otel_scope_[attribute]` labels on all metrics. ([#4505](#4505)) - Prometheus exporter no longer exports `otel_scope_info` metric. ([#4505](#4505)) ### Entities - Define rules for setting identifying attributes. ([#4498](#4498)) - Define rules for entity-resource referencing model. ([#4499](#4499)) ### Common - Move Instrumentation Scope definition from glossary to a dedicated document and use normative language. ([#4488](#4488))
Add description of how entities reference resource attributes and clarifies rules for handling shared descriptive attributes across entities.
Fixes #4370