Have InstrumentationScope use normative language#4488
Merged
carlosalberto merged 23 commits intoopen-telemetry:mainfrom Jun 6, 2025
Merged
Have InstrumentationScope use normative language#4488carlosalberto merged 23 commits intoopen-telemetry:mainfrom
carlosalberto merged 23 commits intoopen-telemetry:mainfrom
Conversation
This also means moving its definition from glossary into the actual specification (common/).
289dd11 to
462ae99
Compare
462ae99 to
c84fa83
Compare
lmolkova
approved these changes
Apr 29, 2025
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Contributor
Author
|
Moved the |
mx-psi
reviewed
May 5, 2025
jsuereth
approved these changes
May 5, 2025
Contributor
jsuereth
left a comment
There was a problem hiding this comment.
Agreed this is needed, and it's a good improvement.
Lots of questions / nits - nothing blocking.
pellared
reviewed
May 6, 2025
tigrannajaryan
approved these changes
May 7, 2025
472f79d to
5872000
Compare
Contributor
Author
|
@jade-guiton-dd @jsuereth Used "software unit" instead of either "code" or "application". That should keep it general/abstract enough IMHO. |
pellared
reviewed
May 9, 2025
Co-authored-by: Jade Guiton <jade.guiton@datadoghq.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
smith
reviewed
May 17, 2025
mx-psi
approved these changes
May 19, 2025
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
MrAlias
reviewed
May 20, 2025
MrAlias
reviewed
May 20, 2025
MrAlias
reviewed
May 20, 2025
MrAlias
reviewed
May 20, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
770021f to
5c71c39
Compare
Contributor
Author
|
@MrAlias Please review. |
dashpole
approved these changes
May 29, 2025
Contributor
Author
|
@MrAlias I think this is good enough and I'd like to merge this in the following days as I do think your feedback has been addressed. Let me know otherwise. |
Merged
via the queue into
open-telemetry:main
with commit Jun 6, 2025
9736aa2
10 of 11 checks passed
This was referenced Jun 6, 2025
Merged
chalin
reviewed
Jun 10, 2025
| @@ -0,0 +1,52 @@ | |||
| <!--- Hugo front matter used to generate the website version of this page: | |||
| linkTitle: Instrumentation Scope | |||
Contributor
There was a problem hiding this comment.
Don't include a linkTitle if it is the same as the time.
chalin
added a commit
to open-telemetry/opentelemetry.io
that referenced
this pull request
Jun 10, 2025
Adjusted links due to open-telemetry/opentelemetry-specification#4488
chalin
added a commit
to open-telemetry/opentelemetry.io
that referenced
this pull request
Jun 10, 2025
Adjusted links due to open-telemetry/opentelemetry-specification#4488
chalin
added a commit
to open-telemetry/opentelemetry.io
that referenced
this pull request
Jun 11, 2025
Adjusted links due to open-telemetry/opentelemetry-specification#4488
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
### Metrics - Prometheus receiver can expect `otel_scope_schema_url` and `otel_scope_[attribute]` labels on all metrics. ([#4505](#4505)) - Prometheus receiver no longer expects `otel_scope_info` metric. ([#4505](#4505)) - Prometheus exporter adds `otel_scope_schema_url` and `otel_scope_[attribute]` labels on all metrics. ([#4505](#4505)) - Prometheus exporter no longer exports `otel_scope_info` metric. ([#4505](#4505)) ### Entities - Define rules for setting identifying attributes. ([#4498](#4498)) - Define rules for entity-resource referencing model. ([#4499](#4499)) ### Common - Move Instrumentation Scope definition from glossary to a dedicated document and use normative language. ([#4488](#4488))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4450
Moved the
InstrumentationScopedefinition from glossary into common/instrumentation-scope.md, and massaged it using normative language, including some examples. Also removed the compile-time concept restriction (as clarified in the related issue, this limitation does not exist in a few SIGs).