Skip to content

Stabilize EventName#4475

Merged
reyang merged 4 commits intoopen-telemetry:mainfrom
pellared:stab-evtname
Apr 11, 2025
Merged

Stabilize EventName#4475
reyang merged 4 commits intoopen-telemetry:mainfrom
pellared:stab-evtname

Conversation

@pellared
Copy link
Member

@pellared pellared commented Apr 7, 2025

Fixes #4459

From the issue comments:

EventName looks to be already supported by:

See also: open-telemetry/opentelemetry-proto#643

@pellared pellared added area:api Cross language API specification issue area:sdk Related to the SDK area:data-model For issues related to data model changelog.opentelemetry.io spec:logs Related to the specification/logs directory labels Apr 7, 2025
@pellared pellared marked this pull request as ready for review April 7, 2025 14:44
@pellared pellared requested review from a team April 7, 2025 14:44
@pellared pellared self-assigned this Apr 7, 2025
@pellared pellared moved this from Todo to In Progress in Go: Logs (GA) Apr 7, 2025
@pellared pellared moved this to In progress in Logs SIG Apr 7, 2025
@jack-berg
Copy link
Member

The question I have is whether or not its appropriate to stabilize part of the event spec while other key parts remain in development. In particular, I'm thinking of the semantic convention guidance on usage of attributes and body. Is this part of the spec close to being stable? I've been involved in various discussions which suggest that there is still active debate, but I may be incorrectly reading the room.

@pellared
Copy link
Member Author

pellared commented Apr 7, 2025

In particular, I'm thinking of the semantic convention guidance on usage of attributes and body.

This does not change the need of having the EventName.

The question I have is whether or not its appropriate to stabilize part of the event spec while other key parts remain in development.

I am more in favor of iterative and incremental development. Especially in places where we already have consensus. This gives opportunity to get more feedback and experience with part of that we are uncertain. The decision how to use attributes vs body would not remove the need of a dedicated event name field.

Copy link
Contributor

@mattmccleary mattmccleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the long-run, I think this will benefit the industry as a first step at standardizing and unifying the language we use re logs, events, etc.

@reyang reyang merged commit 406d3e3 into open-telemetry:main Apr 11, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Logs SIG Apr 11, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in Go: Logs (GA) Apr 11, 2025
@carlosalberto
Copy link
Contributor

@reyang @pellared Is this safe to be included in this month's release?

@reyang
Copy link
Member

reyang commented Apr 11, 2025

@reyang @pellared Is this safe to be included in this month's release?

I think YES. Thanks for checking!

@pellared
Copy link
Member Author

No objection from my side.

@carlosalberto carlosalberto mentioned this pull request Apr 15, 2025
carlosalberto added a commit that referenced this pull request Apr 15, 2025
### Context

- Add context propagation through Environment Variables specification.

([#4454](#4454))
- On Propagators API, stabilize `GetAll` on the `TextMap` Extract.

([#4472](#4472))

### Traces

- Define sampling threshold field in OpenTelemetry TraceState; define
the behavior
of TraceIdRatioBased sampler in terms of W3C Trace Context Level 2
randomness.

([#4166](#4166))

### Metrics

- Clarify SDK behavior for Instrument Advisory Parameter.

([#4389](#4389))

### Logs

- Add `Enabled` opt-in operation to the `LogRecordProcessor`.

([#4439](#4439))
- Stabilize `Logger.Enabled`.

([#4463](#4463))
- Stabilize `EventName`.

([#4475](#4475))

### Baggage

- Add context (baggage) propagation through Environment Variables
specification.

([#4454](#4454))

### Resource

- Add Datamodel for Entities.

([#4442](#4442))

### SDK Configuration

- Convert declarative config env var substitution syntax to ABNF.

([#4448](#4448))
- List declarative config supported SDK extension plugin interfaces.

([#4452](#4452))

---------

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:api Cross language API specification issue area:data-model For issues related to data model area:sdk Related to the SDK changelog.opentelemetry.io spec:logs Related to the specification/logs directory

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Stabilize Event Name parameter of Emit a LogRecord

9 participants