Create initial Entities data model specification.#4442
Merged
jsuereth merged 29 commits intoopen-telemetry:mainfrom Apr 10, 2025
Merged
Create initial Entities data model specification.#4442jsuereth merged 29 commits intoopen-telemetry:mainfrom
jsuereth merged 29 commits intoopen-telemetry:mainfrom
Conversation
Member
|
@jsuereth and other folks from the entities SIG - it would be good to get reviews / approvals from the entities group first to get a signal that this is indeed the agreed direction / consensus of that group. |
dyladan
reviewed
Mar 13, 2025
Member
dyladan
left a comment
There was a problem hiding this comment.
overall looks good. matches what we've been talking about for months. These comments should be considered nits and non-blocking
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
smith
approved these changes
Mar 17, 2025
Contributor
smith
left a comment
There was a problem hiding this comment.
Looks good. Just a few small comments.
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
dyladan
reviewed
Mar 18, 2025
dyladan
approved these changes
Mar 18, 2025
carlosalberto
approved these changes
Mar 21, 2025
kamphaus
reviewed
Mar 23, 2025
lmolkova
approved these changes
Mar 24, 2025
Contributor
Author
|
Given we have enough approvals, would like to merge this by end of week, please take a look. |
jmacd
approved these changes
Apr 8, 2025
kamphaus
approved these changes
Apr 8, 2025
tigrannajaryan
previously requested changes
Apr 8, 2025
Member
tigrannajaryan
left a comment
There was a problem hiding this comment.
Mostly LGTM, just 2 minor comments.
kamphaus
reviewed
Apr 9, 2025
Co-authored-by: Christophe Kamphaus <christophe.kamphaus@gmail.com>
tigrannajaryan
approved these changes
Apr 10, 2025
Merged
carlosalberto
added a commit
that referenced
this pull request
Apr 15, 2025
### Context - Add context propagation through Environment Variables specification. ([#4454](#4454)) - On Propagators API, stabilize `GetAll` on the `TextMap` Extract. ([#4472](#4472)) ### Traces - Define sampling threshold field in OpenTelemetry TraceState; define the behavior of TraceIdRatioBased sampler in terms of W3C Trace Context Level 2 randomness. ([#4166](#4166)) ### Metrics - Clarify SDK behavior for Instrument Advisory Parameter. ([#4389](#4389)) ### Logs - Add `Enabled` opt-in operation to the `LogRecordProcessor`. ([#4439](#4439)) - Stabilize `Logger.Enabled`. ([#4463](#4463)) - Stabilize `EventName`. ([#4475](#4475)) ### Baggage - Add context (baggage) propagation through Environment Variables specification. ([#4454](#4454)) ### Resource - Add Datamodel for Entities. ([#4442](#4442)) ### SDK Configuration - Convert declarative config env var substitution syntax to ABNF. ([#4448](#4448)) - List declarative config supported SDK extension plugin interfaces. ([#4452](#4452)) --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an initial cut at the Entity DataModel specification from OTEP 256.
Changes
entitiesdiretory for storing Entities DataModel.See open-telemetry/opentelemetry-proto#635 for related protocol change.
Prototypes: