Skip to content

Clarify that stdout exporter format is unspecified#4418

Merged
reyang merged 13 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/stdoutlogs-warning
Feb 21, 2025
Merged

Clarify that stdout exporter format is unspecified#4418
reyang merged 13 commits intoopen-telemetry:mainfrom
cijothomas:cijothomas/stdoutlogs-warning

Conversation

@cijothomas
Copy link
Copy Markdown
Member

@cijothomas cijothomas commented Feb 15, 2025

Continuing https://github.com/open-telemetry/opentelemetry-specification/pull/3935/files which got stale and closed.
@MrAlias is the original author of the above PR.

If the wording is agreed, I'll extend to all signals and update changelog. Done!

@cijothomas cijothomas requested review from a team February 15, 2025 02:20
@reyang
Copy link
Copy Markdown
Member

reyang commented Feb 15, 2025

Need a changelog entry.

Copy link
Copy Markdown
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carlosalberto
Copy link
Copy Markdown
Contributor

carlosalberto commented Feb 18, 2025

Overall LGTM. Probably we should change the warning to something along the lines of "Review the file exporter status, in order to verify it is production ready" etc (otherwise this will get eventually outdated).

Copy link
Copy Markdown
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concerns about what message we send with this and the recent blog post here: https://opentelemetry.io/blog/2024/collecting-otel-compliant-java-logs-from-files/

I think if we are going to recommend FileExporter, we should make sure SOMETHING can support that blog article such that we can update its examples.

@pellared
Copy link
Copy Markdown
Member

I think if we are going to recommend FileExporter, we should make sure SOMETHING can support that blog article such that we can update its examples.

It looks like the blog post already showcases the OTLP/JSON FileExporter unless I missed something.

@cijothomas
Copy link
Copy Markdown
Member Author

I have concerns about what message we send with this and the recent blog post here: https://opentelemetry.io/blog/2024/collecting-otel-compliant-java-logs-from-files/

I think if we are going to recommend FileExporter, we should make sure SOMETHING can support that blog article such that we can update its examples.

As clarified by Robert here, Blog already suggests using the FileExporter, which is also what this PR suggests.

carlosalberto and others added 9 commits February 19, 2025 12:29
February 2025 Release.

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([open-telemetry#4368](open-telemetry#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([open-telemetry#4162](open-telemetry#4162))

- Define how SDK implements `Logger.Enabled`.

([open-telemetry#4381](open-telemetry#4381))
- Logs API should have functionality for reusing Standard Attributes.

([open-telemetry#4373](open-telemetry#4373))

- Define syntax for escaping declarative configuration environment
variable
  references.

([open-telemetry#4375](open-telemetry#4375))
- Resolve various declarative config TODOs.

([open-telemetry#4394](open-telemetry#4394))
For your consideration.

Related to the confusion here:
open-telemetry#4420 (comment)
Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
…lper (open-telemetry#4421)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
February 2025 Release.

- Deprecate `exception.escaped` attribute, add link to in-development
semantic-conventions
  on how to record errors across signals.

([open-telemetry#4368](open-telemetry#4368))
- Define randomness value requirements for W3C Trace Context Level 2.

([open-telemetry#4162](open-telemetry#4162))

- Define how SDK implements `Logger.Enabled`.

([open-telemetry#4381](open-telemetry#4381))
- Logs API should have functionality for reusing Standard Attributes.

([open-telemetry#4373](open-telemetry#4373))

- Define syntax for escaping declarative configuration environment
variable
  references.

([open-telemetry#4375](open-telemetry#4375))
- Resolve various declarative config TODOs.

([open-telemetry#4394](open-telemetry#4394))
@cijothomas
Copy link
Copy Markdown
Member Author

Overall LGTM. Probably we should change the warning to something along the lines of "Review the file exporter status, in order to verify it is production ready" etc (otherwise this will get eventually outdated).

Done!

@cijothomas
Copy link
Copy Markdown
Member Author

@jsuereth Please check #4418 (comment) and let me know if any change required.

@reyang reyang merged commit 44829c9 into open-telemetry:main Feb 21, 2025
6 checks passed
@reyang
Copy link
Copy Markdown
Member

reyang commented Feb 21, 2025

@jsuereth Please check #4418 (comment) and let me know if any change required.

Merging, if there is additional feedback from @jsuereth, please send a follow up PR.

@cijothomas cijothomas deleted the cijothomas/stdoutlogs-warning branch February 21, 2025 23:18
@carlosalberto carlosalberto mentioned this pull request Mar 10, 2025
arminru added a commit that referenced this pull request Mar 18, 2025
March 2025 Release.

## v1.43.0 (2025-03-11)

### Traces

- Clarify STDOUT exporter format is unspecified.

([#4418](#4418))

### Metrics

- Clarify STDOUT exporter format is unspecified.

([#4418](#4418))

### Logs

 - Clarify that it is allowed to directly use Logs API.

([#4438](#4438))
- Clarify STDOUT exporter format is unspecified.

([#4418](#4418))

### Supplementary Guidelines

- Add Advanced Processing to Logs Supplementary Guidelines.

([#4407](#4407))

---------

Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants