Deprecate exception.escaped attribute, update exception example#4368
Merged
reyang merged 5 commits intoopen-telemetry:mainfrom Feb 4, 2025
Merged
Deprecate exception.escaped attribute, update exception example#4368reyang merged 5 commits intoopen-telemetry:mainfrom
exception.escaped attribute, update exception example#4368reyang merged 5 commits intoopen-telemetry:mainfrom
Conversation
3 tasks
847e1a0 to
413eed9
Compare
exception.escaped attribute, update exception exampleexception.escaped attribute, update exception example
trask
reviewed
Jan 28, 2025
b8d5071 to
2169716
Compare
trask
approved these changes
Jan 29, 2025
Contributor
|
Overall LGTM, but we should add this note from the semconv repo:
Mostly because the example seems to imply this, but better be super clear IMHO. |
Member
Author
makes sense, @carlosalberto, updated in 0f7d54c |
carlosalberto
approved these changes
Jan 31, 2025
pellared
approved these changes
Feb 3, 2025
Member
pellared
left a comment
There was a problem hiding this comment.
exception.escaped is not used anywhere in OTel Go.
reyang
approved these changes
Feb 4, 2025
Merged
carlosalberto
added a commit
that referenced
this pull request
Feb 18, 2025
February 2025 Release. ### Traces - Deprecate `exception.escaped` attribute, add link to in-development semantic-conventions on how to record errors across signals. ([#4368](#4368)) - Define randomness value requirements for W3C Trace Context Level 2. ([#4162](#4162)) ### Logs - Define how SDK implements `Logger.Enabled`. ([#4381](#4381)) - Logs API should have functionality for reusing Standard Attributes. ([#4373](#4373)) ### SDK Configuration - Define syntax for escaping declarative configuration environment variable references. ([#4375](#4375)) - Resolve various declarative config TODOs. ([#4394](#4394))
cijothomas
pushed a commit
to cijothomas/opentelemetry-specification
that referenced
this pull request
Feb 19, 2025
February 2025 Release. - Deprecate `exception.escaped` attribute, add link to in-development semantic-conventions on how to record errors across signals. ([open-telemetry#4368](open-telemetry#4368)) - Define randomness value requirements for W3C Trace Context Level 2. ([open-telemetry#4162](open-telemetry#4162)) - Define how SDK implements `Logger.Enabled`. ([open-telemetry#4381](open-telemetry#4381)) - Logs API should have functionality for reusing Standard Attributes. ([open-telemetry#4373](open-telemetry#4373)) - Define syntax for escaping declarative configuration environment variable references. ([open-telemetry#4375](open-telemetry#4375)) - Resolve various declarative config TODOs. ([open-telemetry#4394](open-telemetry#4394))
cijothomas
pushed a commit
to cijothomas/opentelemetry-specification
that referenced
this pull request
Feb 19, 2025
February 2025 Release. - Deprecate `exception.escaped` attribute, add link to in-development semantic-conventions on how to record errors across signals. ([open-telemetry#4368](open-telemetry#4368)) - Define randomness value requirements for W3C Trace Context Level 2. ([open-telemetry#4162](open-telemetry#4162)) - Define how SDK implements `Logger.Enabled`. ([open-telemetry#4381](open-telemetry#4381)) - Logs API should have functionality for reusing Standard Attributes. ([open-telemetry#4373](open-telemetry#4373)) - Define syntax for escaping declarative configuration environment variable references. ([open-telemetry#4375](open-telemetry#4375)) - Resolve various declarative config TODOs. ([open-telemetry#4394](open-telemetry#4394))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is follow up on open-telemetry/semantic-conventions#1716 - cross signal guidance on how to record errors (and exceptions) in instrumentations.
Changes
Follow up for open-telemetry/semantic-conventions#1716
exception.escapedattribute is not used in practice within OTel instrumentations (checked Java, .NET, JS. Python, Go, C++ and Rust including contrib repos).OTel instrumentations, in general, don't record handled exceptions, i.e. virtually all exceptions we're recording in non-native instrumentations are expected to escape span scope.
The litmus test whether to record exception on spans is whether the instrumentation is going to set span status to
ERRORdue to this exception.A way to record all sorts of exceptions is being introduced in #4333 and leverages logs along with severity that conveys how critical the exception is in more expressive way than
exception.escapedflag.exception.escaped? semantic-conventions#1516CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary