Add Tracer#Enabled, Instrument#Enabled and corresponding SDK behavior#4063
Merged
jack-berg merged 9 commits intoopen-telemetry:mainfrom Jun 3, 2024
Merged
Add Tracer#Enabled, Instrument#Enabled and corresponding SDK behavior#4063jack-berg merged 9 commits intoopen-telemetry:mainfrom
jack-berg merged 9 commits intoopen-telemetry:mainfrom
Conversation
MrAlias
approved these changes
May 28, 2024
trask
reviewed
May 28, 2024
trask
approved these changes
May 28, 2024
trask
reviewed
May 28, 2024
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
reyang
reviewed
May 29, 2024
reyang
reviewed
May 31, 2024
reyang
approved these changes
May 31, 2024
Member
reyang
left a comment
There was a problem hiding this comment.
LGTM from feature parity perspective.
carlosalberto
approved these changes
May 31, 2024
MrAlias
approved these changes
May 31, 2024
lmolkova
reviewed
May 31, 2024
lmolkova
approved these changes
Jun 3, 2024
jack-berg
commented
Jun 3, 2024
jack-berg
added a commit
to jack-berg/opentelemetry-specification
that referenced
this pull request
Jun 4, 2024
jack-berg
added a commit
to jack-berg/opentelemetry-specification
that referenced
this pull request
Jun 4, 2024
reyang
pushed a commit
that referenced
this pull request
Jun 6, 2024
This was referenced Jun 12, 2024
This was referenced Sep 3, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…open-telemetry#4063) Builds off open-telemetry#4020 to extend the `Enabled` API to `Tracer` and metrics `Instrument`. Adds language to Log SDK, Metrics SDK, and Trace SDK for how scope config is used to resolve the `Enabled` operation. This was discussed in open-telemetry#3867 but punted on in open-telemetry#3877 as [discussed here](open-telemetry#3877 (comment)). --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds off #4020 to extend the
EnabledAPI toTracerand metricsInstrument.Adds language to Log SDK, Metrics SDK, and Trace SDK for how scope config is used to resolve the
Enabledoperation.This was discussed in #3867 but punted on in #3877 as discussed here.