Add Enabled method to Logger#4020
Merged
reyang merged 14 commits intoopen-telemetry:mainfrom May 28, 2024
Merged
Conversation
jack-berg
reviewed
Apr 29, 2024
Member
jack-berg
left a comment
There was a problem hiding this comment.
Nice! Was coincidentally just working on a local branch for this. I think we ought to have symmetry across metrics and traces, but fine pursuing that in a separate PR.
reyang
approved these changes
Apr 29, 2024
jack-berg
reviewed
Apr 29, 2024
yurishkuro
reviewed
Apr 30, 2024
dmathieu
reviewed
Apr 30, 2024
jack-berg
approved these changes
May 13, 2024
dashpole
approved these changes
May 16, 2024
Do not specify required parameters, but explain they can be added in the future.
tsloughter
approved these changes
May 21, 2024
jack-berg
reviewed
May 21, 2024
marcalff
requested changes
May 23, 2024
carlosalberto
pushed a commit
that referenced
this pull request
May 23, 2024
Per #4020 (comment) Some people confuse SHALL with SHOULD. --------- Co-authored-by: Reiley Yang <reyang@microsoft.com>
Leave the return value implementation for implementations specification.
cijothomas
approved these changes
May 23, 2024
cijothomas
reviewed
May 23, 2024
marcalff
approved these changes
May 23, 2024
carlosalberto
approved these changes
May 23, 2024
Member
|
Re-requested review from @jack-berg and @reyang as the contents have changed since their approvals. |
jack-berg
approved these changes
May 23, 2024
reyang
reviewed
May 23, 2024
jmacd
approved these changes
May 28, 2024
4 tasks
jack-berg
added a commit
that referenced
this pull request
Jun 3, 2024
…#4063) Builds off #4020 to extend the `Enabled` API to `Tracer` and metrics `Instrument`. Adds language to Log SDK, Metrics SDK, and Trace SDK for how scope config is used to resolve the `Enabled` operation. This was discussed in #3867 but punted on in #3877 as [discussed here](#3877 (comment)). --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Per open-telemetry#4020 (comment) Some people confuse SHALL with SHOULD. --------- Co-authored-by: Reiley Yang <reyang@microsoft.com>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…open-telemetry#4063) Builds off open-telemetry#4020 to extend the `Enabled` API to `Tracer` and metrics `Instrument`. Adds language to Log SDK, Metrics SDK, and Trace SDK for how scope config is used to resolve the `Enabled` operation. This was discussed in open-telemetry#3867 but punted on in open-telemetry#3877 as [discussed here](open-telemetry#3877 (comment)). --------- Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Reiley Yang <reyang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3917
Knowing if a
LogRecordwill be dropped prior to performing computationally expensive operations helps developers using the Logs Bridge API avoid wasted and expensive work. This adds andEnabledAPI to theLoggerto provide this functionality.This is related to #3877. In that PR
Loggersmay become entirely disabled. TheEnabledmethod included here will help users determine this state.Prototypes