Add support for OTEL_PROPAGATORS#1123
Merged
codeboten merged 6 commits intoopen-telemetry:masterfrom Sep 23, 2020
Merged
Conversation
codeboten
suggested changes
Sep 17, 2020
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Thanks for the PR! I would expect the b3 propagator to also be available through this mechanism and it would great to have a test confirming overriding the environment variable works as expected.
Contributor
|
Also note open-telemetry/opentelemetry-specification#962 for reference on known propagators. |
Contributor
Author
Done, please re-review. |
codeboten
approved these changes
Sep 22, 2020
Contributor
codeboten
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments, LGTM
lzchen
reviewed
Sep 23, 2020
lzchen
reviewed
Sep 23, 2020
lzchen
approved these changes
Sep 23, 2020
alertedsnake
pushed a commit
to alertedsnake/opentelemetry-python
that referenced
this pull request
Sep 25, 2020
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1058
Description
Add support for
OTEL_PROPAGATORSFixes #1058
Type of change
How Has This Been Tested?
test_propagatorsChecklist: