Adding known values for OTEL_PROPAGATORS#962
Merged
carlosalberto merged 1 commit intoopen-telemetry:masterfrom Sep 21, 2020
Merged
Adding known values for OTEL_PROPAGATORS#962carlosalberto merged 1 commit intoopen-telemetry:masterfrom
carlosalberto merged 1 commit intoopen-telemetry:masterfrom
Conversation
8 tasks
carlosalberto
approved these changes
Sep 17, 2020
Contributor
|
Overall LGTM - however, I think we need to add a value to specify B3's formats (single and multiple). As the single part is the default, probably we should have something like:
EDIT: The B3 case may disappear, depending on whether #961 is merged ;) |
Contributor
|
@open-telemetry/specs-approvers Please review this PR. |
Member
|
@carlosalberto Should we wait for #961 to settle then or go with just |
Contributor
|
@arminru As there seems to be initial agreement on having a single B3 Propagator, I'd suggest we go with |
arminru
approved these changes
Sep 18, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds known propagator values to the environment variables specification.