attribute: add BYTESLICE type support by NesterovYehor · Pull Request #7948 · open-telemetry/opentelemetry-go

NesterovYehor · 2026-02-24T14:23:10Z

Add BYTES type to https://pkg.go.dev/go.opentelemetry.io/otel/attribute

Introduces BYTES type and byte
Adds Bytes / BytesValue constructors
Implements hashing support
Adds base64 representation in Emit()
Adds test coverage for constructors, hashing, and set equality

$ go test -run=^$ -bench=BenchmarkByteSlice
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/otel/attribute
cpu: 13th Gen Intel(R) Core(TM) i7-13800H
BenchmarkByteSlice/Value-20             149529567                7.993 ns/op           0 B/op          0 allocs/op
BenchmarkByteSlice/KeyValue-20          136973736                8.768 ns/op           0 B/op          0 allocs/op
BenchmarkByteSlice/AsByteSlice-20       562915658                2.120 ns/op           0 B/op          0 allocs/op
BenchmarkByteSlice/Emit-20              29149410                40.26 ns/op           16 B/op          1 allocs/op
PASS

codecov · 2026-02-24T14:27:39Z

Codecov Report

❌ Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.8%. Comparing base (a00b377) to head (1e33f98).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
log/keyvalue.go	0.0%	3 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #7948   +/-   ##
=====================================
  Coverage   81.8%   81.8%           
=====================================
  Files        308     308           
  Lines      23761   23787   +26     
=====================================
+ Hits       19450   19472   +22     
- Misses      3933    3937    +4     
  Partials     378     378

Files with missing lines	Coverage Δ
attribute/hash.go	`92.0% <100.0%> (+0.5%)`	⬆️
attribute/key.go	`100.0% <100.0%> (ø)`
attribute/kv.go	`100.0% <100.0%> (ø)`
attribute/type_string.go	`60.0% <ø> (ø)`
attribute/value.go	`92.6% <100.0%> (+0.7%)`	⬆️
log/keyvalue.go	`95.6% <0.0%> (-1.5%)`	⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pellared

Overall LGTM. I left a few comments.
Please also add the benchmark results for ``BenchmarkBytes` in the PR description.

pellared · 2026-02-25T15:08:20Z

@NesterovYehor

We would also need to comply with SDK attribute value limits https://opentelemetry.io/docs/specs/otel/common/#anyvalue

if it is a byte array, if its length exceeds that limit (counting each byte as 1), SDKs MUST truncate that value, so that its length is at most equal to the limit,

I propose to do this in a separate PR and also track it in a separate issue. The important thing is that both PRs would need to be shipped in the same release. If you want you can already start working it in a separate branch / draft PR

EDIT: I created #7954

pellared

We do not want breaking changes in log.
See #7948 (comment)

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

pellared

Approved.

Note that this will be merged next week, as we’re planning a release this week. We want to avoid releasing this feature without #7954. This is why I use "Request changes" to block this PR so that it is not accidentally merged.

@NesterovYehor, thanks a lot for your work. I appreciate your patience.

NesterovYehor · 2026-03-31T14:11:58Z

Thanks for all your time and guidance on this PR. Always happy to help.

pellared · 2026-04-07T07:39:18Z

I updated the benchmark results in the description.

pellared · 2026-04-09T14:01:26Z

+	case attribute.BYTESLICE:
+		val := value.AsByteSlice()
+		return BytesValue(val)


This misses a unit test.

pellared · 2026-04-09T14:02:18Z

 	// STRINGSLICE is a slice of strings Type Value.
 	STRINGSLICE
+	// BYTESLICE is a slice of bytes Type Value.
+	BYTESLICE


Missing comparison in sdk/metric/metricdata/metricdatatest/comparisons.go.

Address #7948 (comment)

…ry#8167) Address open-telemetry#7948 (comment)

…emetry#8168) Address open-telemetry#7948 (comment)

### Added - Add `ByteSlice` and `ByteSliceValue` functions for new `BYTESLICE` attribute type in `go.opentelemetry.io/otel/attribute`. (#7948) - Apply attribute value limit to the `KindBytes` attribute type in `go.opentelemetry.io/otel/sdk/log`. (#7990) - Apply attribute value limit to the `BYTESLICE` attribute type in `go.opentelemetry.io/otel/sdk/trace`. (#7990) - Support `BYTESLICE` attributes in `go.opentelemetry.io/otel/trace`. (#8153) - Support `BYTESLICE` attributes in `go.opentelemetry.io/otel/exporters/otlp/otlptrace`. (#8153) - Support `BYTESLICE` attributes in `go.opentelemetry.io/otel/exporters/otlp/otlplog`. (#8153) - Support `BYTESLICE` attributes in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric`. (#8153) - Support `BYTESLICE` attributes in `go.opentelemetry.io/otel/exporters/zipkin`. (#8153) - Add `String` method for `Value` type in `go.opentelemetry.io/otel/attribute`. (#8142) - Add `Slice` and `SliceValue` functions for new `SLICE` attribute type in `go.opentelemetry.io/otel/attribute`. (#8166) - Support `SLICE` attributes in `go.opentelemetry.io/otel/exporters/otlp/otlptrace`. (#8216) - Support `SLICE` attributes in `go.opentelemetry.io/otel/exporters/otlp/otlplog`. (#8216) - Support `SLICE` attributes in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric`. (#8216) - Support `SLICE` attributes in `go.opentelemetry.io/otel/exporters/zipkin`. (#8216) - Apply `AttributeValueLengthLimit` to `attribute.SLICE` type attribute values in `go.opentelemetry.io/otel/sdk/trace`, recursively truncating contained string values. (#8217) - Add `Error` field on `Record` type in `go.opentelemetry.io/otel/log/logtest`. (#8148) - Add `WithMaxRequestSize` option in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#8157) - Add `WithMaxRequestSize` option in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#8157) - Add `WithMaxRequestSize` option in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`. (#8157) - Add `WithMaxRequestSize` option in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#8157) - Add `WithMaxRequestSize` option in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#8157) - Add `WithMaxRequestSize` option in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8157) - Add `Settable` to `go.opentelemetry.io/otel/metric/x` to allow reusing attribute options. (#8178) - Add experimental support for splitting metric data across multiple batches in `go.opentelemetry.io/otel/sdk/metric`. Set `OTEL_GO_X_METRIC_EXPORT_BATCH_SIZE=<max_size>` to enable for all periodic readers. See `go.opentelemetry.io/otel/sdk/metric/internal/x` for feature documentation. (#8071) - Add experimental self-observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`. Enable with `OTEL_GO_X_SELF_OBSERVABILITY=true` environment variable. See `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc/internal/x` for feature documentation. (#8192) - Add experimental self-observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. Enable with `OTEL_GO_X_SELF_OBSERVABILITY=true` environment variable. See `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp/internal/x` for feature documentation. (#8194) - Add experimental self-observability metrics in `go.opentelemetry.io/otel/exporters/stdout/stdoutlog`. Enable with `OTEL_GO_X_SELF_OBSERVABILITY=true` environment variable. See `go.opentelemetry.io/otel/stdout/stdoutlog/internal/x` for feature documentation. (#8263) - Add `WithDefaultAttributes` to `go.opentelemetry.io/otel/metric/x` to support setting default attributes on instruments. (#8135) - Add `go.opentelemetry.io/otel/semconv/v1.41.0` package. The package contains semantic conventions from the `v1.41.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.41.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.40.0`. (#8324) - Add Observable variants of instruments to `go.opentelemetry.io/otel/semconv/v1.41.0` package. (#8350) - Generate explicit histogram bucket boundaries from weaver configuration for HTTP and RPC duration instruments in `go.opentelemetry.io/otel/semconv/v1.41.0`. (#8002) ### Changed - ⚠️ **Breaking Change:** `go.opentelemetry.io/otel/sdk/metric` now applies a default cardinality limit of 2000 to comply with the Metrics SDK specification recommendation. New attribute sets are dropped when the cardinality limit is reached. The measurement of these sets are aggregated into a special attribute set containing `attribute.Bool("otel.metric.overflow", true)`. This can break users who relied on the previous unlimited default. Set `WithCardinalityLimit(0)` or the deprecated `OTEL_GO_X_CARDINALITY_LIMIT=0` environment variable to preserve unlimited cardinality. Note that support for `OTEL_GO_X_CARDINALITY_LIMIT` may be removed in a future release. (#8247) - `ErrorType` in `go.opentelemetry.io/otel/semconv` now unwraps errors created with `fmt.Errorf` when deriving the `error.type` attribute. (#8133) - `go.opentelemetry.io/otel/sdk/log` now unwraps error chains created with `fmt.Errorf` when deriving the `error.type` attribute from errors on log records. (#8133) - `Set.MarshalLog` method in `go.opentelemetry.io/otel/attribute` now uses `Value.String` formatting following the [OpenTelemetry AnyValue representation for non-OTLP protocols](https://opentelemetry.io/docs/specs/otel/common/#anyvalue). (#8169) - Optimize `go.opentelemetry.io/otel/sdk/metric` to return a drop reservoir and short-circuit `Offer` calls to the exemplar reservoir when `exemplar.AlwaysOffFilter` is configured. (#8211) (#8267) - Optimize `go.opentelemetry.io/otel/sdk/metric` to return a drop reservoir for asynchronous instruments when `exemplar.TraceBasedFilter` is configured. (#8286) ### Deprecated - Deprecate `Value.Emit` method in `go.opentelemetry.io/otel/attribute`. Use `Value.String` instead. (#8176) ### Fixed - Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365) - Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365) - Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`. The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365) - Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365) - Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365) - Limit OTLP request size to 64 MiB by default in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. The limit applies before compression, oversized requests are treated as non-retryable errors, and the limit can be configured with the new `WithMaxRequestSize` option. (#8157, #8365) - Fix gzipped request body replay on redirect in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#8135) - Fix gzipped request body replay on redirect in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8152) - `go.opentelemetry.io/otel/exporters/prometheus` now uses `Value.String` formatting for label values following the [OpenTelemetry AnyValue representation for non-OTLP protocols](https://opentelemetry.io/docs/specs/otel/common/#anyvalue). (#8170) - Propagate errors from the exporter when calling `Shutdown` on `BatchSpanProcessor` in `go.opentelemetry.io/otel/sdk/trace`. (#8197) - Fix stale status code reporting on self-observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` and `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8226) - Fix a concurrent `Collect` data race and potential panic in `go.opentelemetry.io/otel/exporters/prometheus` when `WithResourceAsConstantLabels` option is used. (#8227) - Fix race condition in `FixedSizeReservoir` in `go.opentelemetry.io/otel/sdk/metric/exemplar` by reverting #7447. (#8249) - Fix `FixedSizeReservoir` in `go.opentelemetry.io/otel/sdk/metric/exemplar` to safely handle zero size. A capacity check in the constructor initializes the reservoir safely and skips initialization for zero-cap; early returns in `Offer()` and `Collect()` ensure no-op behavior. (#8295) - Fix counting of spans and logs in self-observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`, `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`, `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`, and `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#8254) - Drop conflicting scope attributes named `name`, `version`, or `schema_url` from metric labels in `go.opentelemetry.io/otel/exporters/prometheus`, preserving the dedicated `otel_scope_name`, `otel_scope_version`, and `otel_scope_schema_url` labels. (#8264) - Close schema files opened by `ParseFile` in `go.opentelemetry.io/otel/schema/v1.0` and `go.opentelemetry.io/otel/schema/v1.1`. ([GHSA-995v-fvrw-c78m](GHSA-995v-fvrw-c78m)) - Enforce the 8192-byte baggage size limit during extraction/parsing, changing behavior when the limit is exceeded in `go.opentelemetry.io/otel/baggage` and `go.opentelemetry.io/otel/propagation`. (#8222) - Fix `go.opentelemetry.io/otel/semconv/v1.41.0` to include `Attr*` helper methods for required attributes on observable instruments. (#8361) - Limit baggage extraction error reporting in `go.opentelemetry.io/otel/propagation` to prevent malformed or oversized baggage headers from flooding logs. ([GHSA-5wrp-cwcj-q835](GHSA-5wrp-cwcj-q835))

attribute: add BYTES type support

0489e31

NesterovYehor requested review from MrAlias, XSAM, dashpole, dmathieu, flc1125 and pellared as code owners February 24, 2026 14:23

add changelog entry

c233322

code formation fix

af2f02b

pellared reviewed Feb 24, 2026

View reviewed changes

Comment thread attribute/key_test.go Outdated

Comment thread attribute/kv_test.go Outdated

Comment thread attribute/benchmark_test.go Outdated

Comment thread attribute/hash.go Outdated

pellared added this to the v1.42.0 milestone Feb 24, 2026

pellared changed the title ~~attribute: add BYTES type support~~ [DO NOT MERGE] attribute: add BYTES type support Feb 24, 2026

pellared added this to Go: Logs (GA) Feb 24, 2026

github-project-automation Bot moved this to Todo in Go: Logs (GA) Feb 24, 2026

pellared moved this from Todo to In Progress in Go: Logs (GA) Feb 24, 2026

apply edits

de13076

pellared reviewed Feb 24, 2026

View reviewed changes

Comment thread attribute/internal/attribute.go Outdated

Comment thread attribute/internal/attribute.go Outdated

add test cases in attribute_test.go

793b9d1

pellared reviewed Feb 24, 2026

View reviewed changes

Comment thread attribute/internal/attribute_test.go Outdated

Comment thread attribute/internal/attribute_test.go Outdated

pellared reviewed Feb 24, 2026

View reviewed changes

Comment thread attribute/internal/attribute_test.go Outdated

apply edits to attribute_test.go

95b2ce9

NesterovYehor force-pushed the feat/attribute-bytes-value branch from 87ff3a1 to 95b2ce9 Compare February 24, 2026 22:27

pellared approved these changes Feb 25, 2026

View reviewed changes

Comment thread attribute/benchmark_test.go Outdated

pellared reviewed Feb 25, 2026

View reviewed changes

Comment thread attribute/value.go Outdated

adding asBytes func

1d1cb91

pellared changed the title ~~[DO NOT MERGE] attribute: add BYTES type support~~ attribute: add BYTES type support Feb 25, 2026

pellared changed the title ~~attribute: add BYTES type support~~ [DO NOT MERGE] attribute: add BYTES type support Feb 25, 2026

pellared assigned NesterovYehor Feb 25, 2026

pellared added this to the v1.44.0 milestone Mar 31, 2026

pellared requested changes Mar 31, 2026

View reviewed changes

apply requested changes

00b5556

NesterovYehor force-pushed the feat/attribute-bytes-value branch from ed6fddf to 00b5556 Compare March 31, 2026 12:20

NesterovYehor and others added 3 commits March 31, 2026 14:23

Update attribute/value.go

468c148

Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>

Merge branch 'main' into feat/attribute-bytes-value

7d31835

Merge branch 'main' into feat/attribute-bytes-value

060a7de

NesterovYehor requested review from MrAlias, dmathieu and pellared March 31, 2026 13:31

pellared requested changes Mar 31, 2026

View reviewed changes

MrAlias approved these changes Mar 31, 2026

View reviewed changes

dmathieu approved these changes Apr 1, 2026

View reviewed changes

Merge branch 'main' into feat/attribute-bytes-value

ac8b6cf

pellared approved these changes Apr 7, 2026

View reviewed changes

Update CHANGELOG.md

1e33f98

pellared merged commit 5e9a80b into open-telemetry:main Apr 7, 2026
31 checks passed

github-project-automation Bot moved this from In Progress to Done in Go: Logs (GA) Apr 7, 2026

pellared reviewed Apr 9, 2026

View reviewed changes

This was referenced Apr 9, 2026

metricdatatest: support BYTESLICE attribute comparisons #8167

Merged

test: add test case for ByteSlice in TestValueFromAttribute #8168

Merged

pellared added a commit that referenced this pull request Apr 10, 2026

metricdatatest: support BYTESLICE attribute comparisons (#8167)

ace6b24

Address #7948 (comment)

pellared added a commit that referenced this pull request Apr 10, 2026

test: add test case for ByteSlice in TestValueFromAttribute (#8168)

99d4d7b

Address #7948 (comment)

pellared added a commit to pellared/opentelemetry-go that referenced this pull request Apr 23, 2026

metricdatatest: support BYTESLICE attribute comparisons (open-telemet…

d964cb5

…ry#8167) Address open-telemetry#7948 (comment)

pellared added a commit to pellared/opentelemetry-go that referenced this pull request Apr 23, 2026

test: add test case for ByteSlice in TestValueFromAttribute (open-tel…

cf47713

…emetry#8168) Address open-telemetry#7948 (comment)

pellared mentioned this pull request May 26, 2026

Release 1.44.0 #8376

Merged

Conversation

NesterovYehor commented Feb 24, 2026 • edited by pellared Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pellared left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pellared commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pellared left a comment

Choose a reason for hiding this comment

Uh oh!

pellared left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NesterovYehor commented Mar 31, 2026

Uh oh!

pellared commented Apr 7, 2026

Uh oh!

Uh oh!

pellared Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

pellared Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

pellared Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

pellared Apr 9, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

NesterovYehor commented Feb 24, 2026 •

edited by pellared

Loading

codecov Bot commented Feb 24, 2026 •

edited

Loading

pellared commented Feb 25, 2026 •

edited

Loading

pellared left a comment •

edited

Loading