Skip to content

metricdatatest: support BYTESLICE attribute comparisons#8167

Merged
pellared merged 3 commits into
open-telemetry:mainfrom
pellared:fix-byteslice
Apr 10, 2026
Merged

metricdatatest: support BYTESLICE attribute comparisons#8167
pellared merged 3 commits into
open-telemetry:mainfrom
pellared:fix-byteslice

Conversation

@pellared

@pellared pellared commented Apr 9, 2026

Copy link
Copy Markdown
Member

Address #7948 (comment)

@pellared pellared added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 9, 2026
@pellared pellared changed the title metricdatatest: support byte slice attribute comparisons metricdatatest: support BYTESLICE attribute comparisons Apr 9, 2026
@codecov

codecov Bot commented Apr 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (f92fc89) to head (6012213).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8167     +/-   ##
=======================================
+ Coverage   82.2%   82.3%   +0.1%     
=======================================
  Files        309     309             
  Lines      24235   24238      +3     
=======================================
+ Hits       19928   19960     +32     
+ Misses      3927    3901     -26     
+ Partials     380     377      -3     
Files with missing lines Coverage Δ
...dk/metric/metricdata/metricdatatest/comparisons.go 97.4% <100.0%> (+4.7%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pellared pellared marked this pull request as ready for review April 9, 2026 14:44
@pellared pellared merged commit ace6b24 into open-telemetry:main Apr 10, 2026
31 checks passed
pellared added a commit to pellared/opentelemetry-go that referenced this pull request Apr 23, 2026
@pellared pellared added this to the v1.44.0 milestone May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants