Skip to content

[Enhancement] Revise pre-commit-hooks#1315

Merged
MeowZheng merged 1 commit intoopen-mmlab:masterfrom
MeowZheng:copy-right
Feb 23, 2022
Merged

[Enhancement] Revise pre-commit-hooks#1315
MeowZheng merged 1 commit intoopen-mmlab:masterfrom
MeowZheng:copy-right

Conversation

@MeowZheng
Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add check-algo-redame and check-copyright hooks ref: open-mmlab/mmdeploy#166

Modification

  • modify pre-commit hook yml
  • Add copyrights on files

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 23, 2022

Codecov Report

Merging #1315 (0244a74) into master (8cf333c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1315   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         131      131           
  Lines        7599     7599           
  Branches     1264     1264           
=======================================
  Hits         6858     6858           
  Misses        531      531           
  Partials      210      210           
Flag Coverage Δ
unittests 90.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/coco_stuff.py 87.50% <ø> (ø)
mmseg/datasets/dark_zurich.py 83.33% <ø> (ø)
mmseg/datasets/isaid.py 94.11% <ø> (ø)
mmseg/datasets/night_driving.py 83.33% <ø> (ø)
mmseg/models/backbones/icnet.py 97.50% <ø> (ø)
mmseg/models/backbones/twins.py 99.40% <ø> (ø)
mmseg/models/decode_heads/dpt_head.py 96.15% <ø> (ø)
mmseg/models/decode_heads/isa_head.py 96.00% <ø> (ø)
mmseg/models/necks/ic_neck.py 100.00% <ø> (ø)
mmseg/models/utils/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cf333c...0244a74. Read the comment docs.

@MeowZheng MeowZheng merged commit e5cd755 into open-mmlab:master Feb 23, 2022
ZhimingNJ pushed a commit to AetrexTechnology/mmsegmentation that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants