Skip to content

Add a new pre-commit-hook to automatically add a copyright#166

Merged
RunningLeon merged 3 commits intoopen-mmlab:masterfrom
zhouzaida:add-copyright
Feb 23, 2022
Merged

Add a new pre-commit-hook to automatically add a copyright#166
RunningLeon merged 3 commits intoopen-mmlab:masterfrom
zhouzaida:add-copyright

Conversation

@zhouzaida
Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add a new pre-commit-hook to automatically add a copyright.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 17, 2022

Codecov Report

Merging #166 (f2dcd28) into master (59470fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   66.79%   66.79%           
=======================================
  Files         188      188           
  Lines        6191     6191           
  Branches      957      957           
=======================================
  Hits         4135     4135           
  Misses       1765     1765           
  Partials      291      291           
Flag Coverage Δ
unittests 66.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...deploy/codebase/mmdet/core/ops/detection_output.py 77.77% <ø> (ø)
mmdeploy/codebase/mmdet/core/ops/prior_box.py 70.00% <ø> (ø)
mmdeploy/codebase/mmdet/models/backbones.py 15.78% <ø> (ø)
...debase/mmdet/models/dense_heads/base_dense_head.py 30.61% <ø> (ø)
mmdeploy/codebase/mmdet/models/necks.py 50.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59470fe...f2dcd28. Read the comment docs.

@zhouzaida zhouzaida marked this pull request as draft February 21, 2022 09:34
@zhouzaida zhouzaida marked this pull request as ready for review February 21, 2022 11:42
Copy link
Copy Markdown
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit f0c110e into open-mmlab:master Feb 23, 2022
@zhouzaida zhouzaida deleted the add-copyright branch February 23, 2022 04:53
hanrui1sensetime pushed a commit to hanrui1sensetime/mmdeploy that referenced this pull request Nov 25, 2022
ewernn pushed a commit to ewernn/mmdeploy that referenced this pull request Nov 17, 2025
ewernn pushed a commit to ewernn/mmdeploy that referenced this pull request Nov 17, 2025
…b#166)

* Add a new pre-commit-hook to automatically add copyright

* Add a new pre-commit-hook to automatically add copyright

* append 'demo' and 'tools' directories to .pre-commit-config.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants