fix: fixing sync return format missing flag layer, adding full e2e suite by aepfli · Pull Request #1827 · open-feature/flagd

aepfli · 2025-11-27T14:11:28Z

with #1797 we introduced this bug, that the format of the response is not correct.

current state:

{ 
    flagConfiguration: {/* flag object */}
}

should be:

{ 
    flagConfiguration: {
       flags: {/* flag object */}
    }
}

Clarification from @toddbaert - this is an UNRELEASED bug so far.

netlify · 2025-11-27T14:11:35Z

✅ Deploy Preview for polite-licorice-3db33c ready!

Name	Link
🔨 Latest commit	`7178181`
🔍 Latest deploy log	https://app.netlify.com/projects/polite-licorice-3db33c/deploys/693c30f468d8410008d8b788
😎 Deploy Preview	https://deploy-preview-1827--polite-licorice-3db33c.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

gemini-code-assist · 2025-11-27T14:11:48Z

Summary of Changes

Hello @aepfli, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical bug in the flag synchronization API where the JSON response format was incorrect. Previously, flag data was directly returned without being encapsulated under a designated 'flags' key. This fix ensures that all flag data is properly nested, aligning the API's output with the expected structure and preventing potential parsing issues for consumers.

Highlights

Corrected Sync API Response Format: The SyncFlags and FetchAllFlags gRPC methods now correctly wrap the flag data within a flags key in the JSON response. This addresses a bug introduced in a previous PR where the flag layer was missing from the synchronization response, ensuring the output adheres to the expected format.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

aepfli · 2025-11-27T14:12:11Z

we definitely need to get everything going for #1821 to prevent this issue in the future

gemini-code-assist

Code Review

This pull request addresses a bug in the flag sync response format by adding a missing 'flags' layer. The changes in SyncFlags and FetchAllFlags correctly implement this fix. I've suggested a small refactoring to abstract the duplicated logic for creating this response structure into a helper function to improve code maintainability. Additionally, it's worth noting that the existing tests may not be robust enough to catch this kind of structural regression in the JSON response. Strengthening them by unmarshalling and asserting on the response structure could prevent similar issues in the future.

toddbaert · 2025-11-27T16:07:46Z

Yep, 💯 I found this late last week and was intending to open a bug as well. We need to enhance our testing to run in-process tests to find this - there's much less surface area to test with in-process mode on flagd itself (since evaluation happens in the workload) but it's required to find things like this.

Thanks!

aepfli · 2025-11-28T09:18:16Z

/gemini review

gemini-code-assist

Code Review

This pull request correctly fixes a bug in the flag synchronization response format by adding the missing 'flags' layer. The changes in flagd/pkg/service/flag-sync/handler.go are appropriate. I've included a suggestion to refactor some duplicated code to improve maintainability. Additionally, this PR introduces a significant and beneficial refactoring of the integration tests, moving to a testcontainers-based setup, which is a great improvement for test reliability and isolation. I've noted one minor typo in the new test configuration.

alexandraoberaigner

Looks good to me! Just added some questions
Awesome to see the testcontainers/testframework here too 🎉

…ider Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

Co-authored-by: alexandraoberaigner <82218944+alexandraoberaigner@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

sonarqubecloud · 2025-12-12T15:13:29Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

toddbaert

Thanks for the fix, but thanks way more for integrating the entire e2e suite. Very very good to have.

toddbaert · 2025-12-12T16:41:51Z

@aepfli ... @alexandraoberaigner has some small questions/nits, but not blockers for me. I've rebased, so I'll merge this soon unless you want to address those small nits.

🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.13.0</summary> ## [0.13.0](flagd/v0.12.9...flagd/v0.13.0) (2025-12-23) ### 🐛 Bug Fixes * fixing sync return format missing flag layer, adding full e2e suite ([#1827](#1827)) ([570693d](570693d)) * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) ### ✨ New Features * add support for http-based ofrep metrics ([#1803](#1803)) ([fcd19b3](fcd19b3)) * cleanup evaluator interface ([#1793](#1793)) ([aa504f7](aa504f7)) * enable parsing of array flag configurations for flagd ([#1797](#1797)) ([97c6ffa](97c6ffa)) * multi-project support via selectors and flagSetId namespacing ([#1702](#1702)) ([f9ce46f](f9ce46f)) * normalize selector in sync (use header as in OFREP and RPC) ([#1815](#1815)) ([c1f06cb](c1f06cb)) ### 🧹 Chore * **refactor:** use memdb for flag storage ([#1697](#1697)) ([5c5c1cf](5c5c1cf)) ### 🔄 Refactoring * store cleanup ([#1705](#1705)) ([bcff8d7](bcff8d7)) </details> <details><summary>flagd-proxy: 0.8.1</summary> ## [0.8.1](flagd-proxy/v0.8.0...flagd-proxy/v0.8.1) (2025-12-23) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) </details> <details><summary>core: 0.13.0</summary> ## [0.13.0](core/v0.12.1...core/v0.13.0) (2025-12-23) ### ⚠ BREAKING CHANGES * enable parsing of array flag configurations for flagd ([#1797](#1797)) * cleanup evaluator interface ([#1793](#1793)) * removes the `fractionalEvaluation` operator since it has been replaced with `fractional`. ([#1704](#1704)) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1825](#1825)) ([44edcc9](44edcc9)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) ### ✨ New Features * Add OAuth support for HTTP Sync ([#1791](#1791)) ([268fd75](268fd75)) * Add OTEL default variables ([#1812](#1812)) ([c2e3fc6](c2e3fc6)) * allow null flagSetId Selector, restrict Selector to single key-value-pairs ([#1708](#1708)) ([#1811](#1811)) ([c12a0ae](c12a0ae)) * change jsonschema parser ([#1794](#1794)) ([bf3f722](bf3f722)) * cleanup evaluator interface ([#1793](#1793)) ([aa504f7](aa504f7)) * enable parsing of array flag configurations for flagd ([#1797](#1797)) ([97c6ffa](97c6ffa)) * multi-project support via selectors and flagSetId namespacing ([#1702](#1702)) ([f9ce46f](f9ce46f)) ### 🧹 Chore * **refactor:** use memdb for flag storage ([#1697](#1697)) ([5c5c1cf](5c5c1cf)) * removes the `fractionalEvaluation` operator since it has been replaced with `fractional`. ([#1704](#1704)) ([3228ad8](3228ad8)) ### 🔄 Refactoring * remove deprecated bearerToken option ([#1816](#1816)) ([efda06a](efda06a)) * removed unused Selector from Flag and Store. ([#1747](#1747)) ([1083005](1083005)) * store cleanup ([#1705](#1705)) ([bcff8d7](bcff8d7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>

aepfli requested review from a team as code owners November 27, 2025 14:11

dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 27, 2025

gemini-code-assist Bot reviewed Nov 27, 2025

View reviewed changes

Comment thread flagd/pkg/service/flag-sync/handler.go Outdated

Comment thread flagd/pkg/service/flag-sync/handler.go Outdated

aepfli force-pushed the fix/correct-format-for-return-value branch from 7ccd39b to 402a01a Compare November 27, 2025 15:15

dosubot Bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 27, 2025

aepfli force-pushed the fix/correct-format-for-return-value branch from bcfd5dc to 69a17a5 Compare November 27, 2025 16:02

aepfli force-pushed the fix/correct-format-for-return-value branch from 69a17a5 to bb91ffa Compare November 28, 2025 07:47

aepfli commented Nov 28, 2025

View reviewed changes

Comment thread test/integration/integration_test.go Outdated

aepfli force-pushed the fix/correct-format-for-return-value branch from bb91ffa to 0a5755e Compare November 28, 2025 09:17

gemini-code-assist Bot reviewed Nov 28, 2025

View reviewed changes

aepfli force-pushed the fix/correct-format-for-return-value branch from dc8a8e0 to 6392628 Compare November 28, 2025 12:28

alexandraoberaigner approved these changes Dec 10, 2025

View reviewed changes

Comment thread test/integration/integration_test.go

Comment thread test/integration/go.mod

Comment thread .github/workflows/build.yaml Outdated

aepfli and others added 6 commits December 12, 2025 10:12

test: using e2e framework to test flagd via go-sdk-contrib flagd prov…

e0d3372

…ider Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

fixup: update harnesS

463d491

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

fix: fixing sync return format missing flag layer

a6d8208

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

fixup: update deps and add exclusions

93a63d8

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

fixup: gemini feedback

fe47d4a

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

Update .github/workflows/build.yaml

7178181

Co-authored-by: alexandraoberaigner <82218944+alexandraoberaigner@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

toddbaert force-pushed the fix/correct-format-for-return-value branch from 3f29eed to 7178181 Compare December 12, 2025 15:12

toddbaert changed the title ~~fix: fixing sync return format missing flag layer~~ fix: fixing sync return format missing flag layer, adding full e2e suite Dec 12, 2025

toddbaert approved these changes Dec 12, 2025

View reviewed changes

toddbaert mentioned this pull request Dec 12, 2025

test: using e2e framework to test flagd via go-sdk-contrib flagd provider #1821

Closed

toddbaert merged commit 570693d into open-feature:main Dec 15, 2025
18 checks passed

github-actions Bot mentioned this pull request Dec 15, 2025

chore: release main #1699

Merged

Conversation

aepfli commented Nov 27, 2025 • edited by toddbaert Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify Bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for polite-licorice-3db33c ready!

Uh oh!

gemini-code-assist Bot commented Nov 27, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

aepfli commented Nov 27, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Nov 27, 2025

Uh oh!

Uh oh!

aepfli commented Nov 28, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

alexandraoberaigner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud Bot commented Dec 12, 2025

Quality Gate passed

Uh oh!

toddbaert left a comment

Choose a reason for hiding this comment

Uh oh!

toddbaert commented Dec 12, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aepfli commented Nov 27, 2025 •

edited by toddbaert

Loading

netlify Bot commented Nov 27, 2025 •

edited

Loading