Skip to content

refactor!: Remove deprecated bearerToken option#1816

Merged
tangenti merged 2 commits into
open-feature:mainfrom
m-olko:remove_bearerToken
Nov 3, 2025
Merged

refactor!: Remove deprecated bearerToken option#1816
tangenti merged 2 commits into
open-feature:mainfrom
m-olko:remove_bearerToken

Conversation

@m-olko

@m-olko m-olko commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

This PR

Removes deprecated bearerToken option from all references in code and in documentation. It also updates some tests, to use authHeader with Bearer type instead.

Related Issues

Fixes #1687

Notes

This may be breaking change, as it removes field from Sync struct. I updated all local tests and resources, but let me know if there are any other resources that are maintained by flagd community, that might create Sync struct with that field.

@m-olko
refactor!: Remove deprecated bearerToken option
a241855 
Signed-off-by: Marcin Olko <molko@google.com>
@m-olko m-olko requested review from a team as code owners October 27, 2025 10:37
@netlify

netlify Bot commented Oct 27, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 7871e16
🔍 Latest deploy log https://app.netlify.com/projects/polite-licorice-3db33c/deploys/6903856fc5d03100087dda93
😎 Deploy Preview https://deploy-preview-1816--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 27, 2025
@gemini-code-assist

gemini-code-assist Bot commented Oct 27, 2025

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @m-olko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactor to remove the deprecated bearerToken configuration option, standardizing all HTTP synchronization authentication to use the more flexible authHeader field. This change simplifies the authentication mechanism by consolidating it into a single, comprehensive option, requiring users to adapt their configurations accordingly. The update impacts core synchronization logic, configuration parsing, and associated tests, ensuring a consistent and future-proof approach to authentication.

Highlights

  • Removal of Deprecated bearerToken Option: The bearerToken option has been completely removed from the codebase, including its definition in the Sync struct, configuration parsing logic, and usage in HTTP sync operations. This streamlines authentication to use the more generic authHeader field.
  • Standardization to authHeader: All authentication for HTTP syncs now exclusively relies on the authHeader field. This field allows for full control over the Authorization header, supporting various schemes like Bearer, Basic, etc., directly within the header value.
  • Updated Tests and Documentation: Existing test cases have been updated to reflect the removal of bearerToken and now utilize authHeader for authentication. The project documentation has also been revised to remove references to the deprecated bearerToken and guide users towards authHeader.
  • Potential Breaking Change: The removal of the bearerToken field from the Sync struct is a breaking change. Users who previously relied on bearerToken will need to update their configurations to use authHeader with the appropriate Bearer prefix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 27, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes the deprecated bearerToken option across the entire codebase. The changes are thorough, touching not only the core logic in http_sync.go and the SourceConfig struct, but also updating all relevant tests and documentation to reflect the removal. The migration to using authHeader is handled correctly, with examples and tests updated to show the new expected usage (e.g., authHeader: "Bearer <token>"). The PR correctly identifies this as a breaking change. The code quality is high, and the changes are clean and well-executed. No issues were found.

aepfli
aepfli approved these changes Oct 28, 2025
View reviewed changes

@aepfli aepfli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@m-olko
Merge branch 'main' into remove_bearerToken
7871e16 
Signed-off-by: m-olko <molko@google.com>
@sonarqubecloud

sonarqubecloud Bot commented Oct 30, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tangenti tangenti merged commit efda06a into open-feature:main Nov 3, 2025
18 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 29, 2025
Merged
toddbaert added a commit that referenced this pull request Dec 24, 2025
@github-actions @toddbaert
chore: release main (#1699)
814a6ac 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.13.0</summary>

##
[0.13.0](flagd/v0.12.9...flagd/v0.13.0)
(2025-12-23)


### 🐛 Bug Fixes

* fixing sync return format missing flag layer, adding full e2e suite
([#1827](#1827))
([570693d](570693d))
* **security:** update module github.com/go-viper/mapstructure/v2 to
v2.4.0 [security]
([#1784](#1784))
([037e30b](037e30b))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1826](#1826))
([7e0762b](7e0762b))


### ✨ New Features

* add support for http-based ofrep metrics
([#1803](#1803))
([fcd19b3](fcd19b3))
* cleanup evaluator interface
([#1793](#1793))
([aa504f7](aa504f7))
* enable parsing of array flag configurations for flagd
([#1797](#1797))
([97c6ffa](97c6ffa))
* multi-project support via selectors and flagSetId namespacing
([#1702](#1702))
([f9ce46f](f9ce46f))
* normalize selector in sync (use header as in OFREP and RPC)
([#1815](#1815))
([c1f06cb](c1f06cb))


### 🧹 Chore

* **refactor:** use memdb for flag storage
([#1697](#1697))
([5c5c1cf](5c5c1cf))


### 🔄 Refactoring

* store cleanup
([#1705](#1705))
([bcff8d7](bcff8d7))
</details>

<details><summary>flagd-proxy: 0.8.1</summary>

##
[0.8.1](flagd-proxy/v0.8.0...flagd-proxy/v0.8.1)
(2025-12-23)


### 🐛 Bug Fixes

* **security:** update module github.com/go-viper/mapstructure/v2 to
v2.4.0 [security]
([#1784](#1784))
([037e30b](037e30b))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1826](#1826))
([7e0762b](7e0762b))
</details>

<details><summary>core: 0.13.0</summary>

##
[0.13.0](core/v0.12.1...core/v0.13.0)
(2025-12-23)


### ⚠ BREAKING CHANGES

* enable parsing of array flag configurations for flagd
([#1797](#1797))
* cleanup evaluator interface
([#1793](#1793))
* removes the `fractionalEvaluation` operator since it has been replaced
with `fractional`.
([#1704](#1704))

### 🐛 Bug Fixes

* **security:** update module github.com/go-viper/mapstructure/v2 to
v2.4.0 [security]
([#1784](#1784))
([037e30b](037e30b))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1825](#1825))
([44edcc9](44edcc9))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1826](#1826))
([7e0762b](7e0762b))


### ✨ New Features

* Add OAuth support for HTTP Sync
([#1791](#1791))
([268fd75](268fd75))
* Add OTEL default variables
([#1812](#1812))
([c2e3fc6](c2e3fc6))
* allow null flagSetId Selector, restrict Selector to single
key-value-pairs
([#1708](#1708))
([#1811](#1811))
([c12a0ae](c12a0ae))
* change jsonschema parser
([#1794](#1794))
([bf3f722](bf3f722))
* cleanup evaluator interface
([#1793](#1793))
([aa504f7](aa504f7))
* enable parsing of array flag configurations for flagd
([#1797](#1797))
([97c6ffa](97c6ffa))
* multi-project support via selectors and flagSetId namespacing
([#1702](#1702))
([f9ce46f](f9ce46f))


### 🧹 Chore

* **refactor:** use memdb for flag storage
([#1697](#1697))
([5c5c1cf](5c5c1cf))
* removes the `fractionalEvaluation` operator since it has been replaced
with `fractional`.
([#1704](#1704))
([3228ad8](3228ad8))


### 🔄 Refactoring

* remove deprecated bearerToken option
([#1816](#1816))
([efda06a](efda06a))
* removed unused Selector from Flag and Store.
([#1747](#1747))
([1083005](1083005))
* store cleanup
([#1705](#1705))
([bcff8d7](bcff8d7))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aepfli aepfli aepfli approved these changes

@tangenti tangenti tangenti approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove deprecated bearerToken option

3 participants

@m-olko @aepfli @tangenti