feat: support new flagd.evaluation and flagd.sync schemas by bacherfl · Pull Request #1083 · open-feature/flagd

bacherfl · 2023-12-15T09:26:20Z

This PR introduces support for the newly introduced evaluation and sync schemas.

Supporting both the old and new schemas involves some duplication, but I tried to keep it as minimal as possible. I'm of course open for suggestions for any ideas on how to make this simpler :)

See reasoning for new naming here.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

…hemas # Conflicts: # core/go.sum

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

netlify · 2023-12-15T09:26:26Z

✅ Deploy Preview for polite-licorice-3db33c ready!

Name	Link
🔨 Latest commit	`8102fcf`
🔍 Latest deploy log	https://app.netlify.com/sites/polite-licorice-3db33c/deploys/658444912fbb3f0008483478
😎 Deploy Preview	https://deploy-preview-1083--polite-licorice-3db33c.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

codecov · 2023-12-15T09:29:23Z

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (dea8c78) 72.93% compared to head (8102fcf) 73.53%.
Report is 1 commits behind head on main.

Files	Patch %	Lines
...e/pkg/service/flag-evaluation/flag_evaluator_v2.go	75.91%	45 Missing and 1 partial ⚠️
...kg/service/flag-evaluation/flag_evaluator_types.go	90.90%	4 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1083      +/-   ##
==========================================
+ Coverage   72.93%   73.53%   +0.59%     
==========================================
  Files          31       32       +1     
  Lines        2864     3113     +249     
==========================================
+ Hits         2089     2289     +200     
- Misses        670      717      +47     
- Partials      105      107       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

core/pkg/service/flag-evaluation/flag_evaluator_v2.go

core/pkg/service/flag-evaluation/flag_evaluator.go

toddbaert · 2023-12-18T18:26:09Z

@bacherfl since you're going through this, would you mind sprinkling references to this new issue I created where relevant? That way it'll be super easy to make sure that we remove all the right stuff by just searching for 1088.

toddbaert · 2023-12-18T18:28:17Z

Closes #1029

This PR introduces support for the newly introduced evaluation and sync schemas.

Supporting both the old and new schemas involves some duplication, but I tried to keep it as minimal as possible. I'm of course open for suggestions for any ideas on how to make this simpler :)

I think the effort we should put into reducing duplication that we know will be deleted should be low, so unless the solutions are very easy, I'm fine with it as is.

toddbaert · 2023-12-18T18:45:07Z

Can you update all e2e tests and documentation to use the new paths? I think a good approach might be to simply search for schema.v1.Service and sync.v1 and replace them with the new paths and RPC names. This way new and old users will be more likely to use the non-deprecated stuff.

core/pkg/service/sync/sync_metrics.go

toddbaert

Manually tested and this works for me.

I have 2 small concerns: this and this.

This is optional, but would be nice to make the subsequent removal easier later.

We also could consider adding a middleware (or something like that) that would log a one-time warning when the old endpoint is used.

bacherfl · 2023-12-19T12:28:43Z

Manually tested and this works for me.

I have 2 small concerns: this and this.

This is optional, but would be nice to make the subsequent removal easier later.

We also could consider adding a middleware (or something like that) that would log a one-time warning when the old endpoint is used.

thanks for the review, I will adapt the PR accordingly

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

toddbaert

Looks great! Thanks a lot!

core/pkg/service/flag-evaluation/flag_evaluator_v2.go

🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.8.0</summary> ## [0.8.0](flagd/v0.7.2...flagd/v0.8.0) (2023-12-22) ### ⚠ BREAKING CHANGES * remove deprecated flags ([#1075](#1075)) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.2 ([#1056](#1056)) ([81e83ea](81e83ea)) * **deps:** update module github.com/spf13/viper to v1.18.0 ([#1060](#1060)) ([9dfa689](9dfa689)) ### 🧹 Chore * refactoring component structure ([#1044](#1044)) ([0c7f78a](0c7f78a)) * remove deprecated flags ([#1075](#1075)) ([49f6fe5](49f6fe5)) </details> <details><summary>flagd-proxy: 0.4.0</summary> ## [0.4.0](flagd-proxy/v0.3.2...flagd-proxy/v0.4.0) (2023-12-22) ### ⚠ BREAKING CHANGES * remove deprecated flags ([#1075](#1075)) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.2 ([#1056](#1056)) ([81e83ea](81e83ea)) * **deps:** update module github.com/spf13/viper to v1.18.0 ([#1060](#1060)) ([9dfa689](9dfa689)) ### 🧹 Chore * refactoring component structure ([#1044](#1044)) ([0c7f78a](0c7f78a)) * remove deprecated flags ([#1075](#1075)) ([49f6fe5](49f6fe5)) </details> <details><summary>core: 0.7.3</summary> ## [0.7.3](core/v0.7.2...core/v0.7.3) (2023-12-22) ### 🐛 Bug Fixes * **deps:** update golang.org/x/exp digest to 6522937 ([#1032](#1032)) ([78b23d2](78b23d2)) * **deps:** update module connectrpc.com/connect to v1.13.0 ([#1070](#1070)) ([63f86ea](63f86ea)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.4.0 ([#1068](#1068)) ([5c5d5ab](5c5d5ab)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.5.2 ([#1059](#1059)) ([cefea3e](cefea3e)) * **deps:** update module google.golang.org/grpc to v1.60.0 ([#1074](#1074)) ([bf3e9d8](bf3e9d8)) * **deps:** update module google.golang.org/grpc to v1.60.1 ([#1092](#1092)) ([5bf1368](5bf1368)) * make sure sync builder is initialized to avoid nil pointer access ([#1076](#1076)) ([ebcd616](ebcd616)) ### ✨ New Features * support new flagd.evaluation and flagd.sync schemas ([#1083](#1083)) ([e9728aa](e9728aa)) ### 🧹 Chore * refactoring component structure ([#1044](#1044)) ([0c7f78a](0c7f78a)) * renaming of evaluation components ([#1064](#1064)) ([d39f31d](d39f31d)) * use client-go library for retrieving FeatureFlag CRs ([#1077](#1077)) ([c86dff0](c86dff0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

bacherfl added 5 commits December 13, 2023 13:27

chore: support new flagd evaluation schemas

39bc5c7

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

chore: support new flagd sync schemas

bd61ced

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

trigger build

857b6a9

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

Merge remote-tracking branch 'upstream/main' into feat/support-new-sc…

c1e489b

…hemas # Conflicts: # core/go.sum

go mod tidy

3ae7da8

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

bacherfl changed the title ~~Feat/support new schemas~~ feat: support new flagd.evaluation and flagd.sync schemas Dec 15, 2023

bacherfl added 4 commits December 15, 2023 11:39

added unit tests for new handler

916b674

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

remove unneeded mux handler

cde6725

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

fix linting

aa87f04

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

fix linting

2438284

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

bacherfl marked this pull request as ready for review December 18, 2023 10:20

bacherfl requested a review from a team December 18, 2023 10:20

toddbaert reviewed Dec 18, 2023

View reviewed changes

core/pkg/service/flag-evaluation/flag_evaluator_v2.go Outdated Show resolved Hide resolved

toddbaert reviewed Dec 18, 2023

View reviewed changes

core/pkg/service/flag-evaluation/flag_evaluator.go Show resolved Hide resolved

toddbaert mentioned this pull request Dec 18, 2023

Remove deprecated proto compatibility #1088

Open

toddbaert self-requested a review December 18, 2023 18:45

toddbaert reviewed Dec 18, 2023

View reviewed changes

core/pkg/service/sync/sync_metrics.go Outdated Show resolved Hide resolved

toddbaert requested changes Dec 18, 2023

View reviewed changes

updated endpoints to use new api in docs and e2e tests

735a94a

Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>

toddbaert requested review from beeme1mr, craigpastro, thisthat and toddbaert December 19, 2023 14:26

toddbaert approved these changes Dec 19, 2023

View reviewed changes

toddbaert requested review from RealAnna and odubajDT December 20, 2023 20:11

beeme1mr approved these changes Dec 21, 2023

View reviewed changes

thisthat approved these changes Dec 21, 2023

View reviewed changes

thisthat reviewed Dec 21, 2023

View reviewed changes

core/pkg/service/flag-evaluation/flag_evaluator_v2.go Show resolved Hide resolved

Merge branch 'main' into feat/support-new-schemas

8102fcf

toddbaert merged commit e9728aa into open-feature:main Dec 21, 2023

github-actions bot mentioned this pull request Dec 21, 2023

chore: release main #1057

Merged

zeezdev mentioned this pull request Jan 3, 2024

[BUG] There is no "value" key in the evaluation response #1116

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support new flagd.evaluation and flagd.sync schemas#1083

feat: support new flagd.evaluation and flagd.sync schemas#1083
toddbaert merged 11 commits intoopen-feature:mainfrom
bacherfl:feat/support-new-schemas

bacherfl commented Dec 15, 2023 •

edited by toddbaert

Loading

Uh oh!

netlify bot commented Dec 15, 2023 •

edited

Loading

Uh oh!

codecov bot commented Dec 15, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Dec 18, 2023

Uh oh!

toddbaert commented Dec 18, 2023

Uh oh!

toddbaert commented Dec 18, 2023 •

edited

Loading

Uh oh!

Uh oh!

toddbaert left a comment •

edited

Loading

Uh oh!

bacherfl commented Dec 19, 2023

Uh oh!

toddbaert left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

bacherfl commented Dec 15, 2023 • edited by toddbaert Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for polite-licorice-3db33c ready!

Uh oh!

codecov bot commented Dec 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Dec 18, 2023

Uh oh!

toddbaert commented Dec 18, 2023

Uh oh!

toddbaert commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

toddbaert left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bacherfl commented Dec 19, 2023

Uh oh!

toddbaert left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bacherfl commented Dec 15, 2023 •

edited by toddbaert

Loading

netlify bot commented Dec 15, 2023 •

edited

Loading

codecov bot commented Dec 15, 2023 •

edited

Loading

toddbaert commented Dec 18, 2023 •

edited

Loading

toddbaert left a comment •

edited

Loading