fix: make sure sync builder is initialized to avoid nil pointer access#1076
Merged
toddbaert merged 1 commit intoopen-feature:mainfrom Dec 12, 2023
Merged
Conversation
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
==========================================
- Coverage 72.91% 72.80% -0.11%
==========================================
Files 31 31
Lines 2865 2865
==========================================
- Hits 2089 2086 -3
- Misses 672 674 +2
- Partials 104 105 +1 ☔ View full report in Codecov by Sentry. |
odubajDT
approved these changes
Dec 12, 2023
toddbaert
approved these changes
Dec 12, 2023
Merged
toddbaert
pushed a commit
that referenced
this pull request
Dec 22, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.8.0</summary> ## [0.8.0](flagd/v0.7.2...flagd/v0.8.0) (2023-12-22) ### ⚠ BREAKING CHANGES * remove deprecated flags ([#1075](#1075)) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.2 ([#1056](#1056)) ([81e83ea](81e83ea)) * **deps:** update module github.com/spf13/viper to v1.18.0 ([#1060](#1060)) ([9dfa689](9dfa689)) ### 🧹 Chore * refactoring component structure ([#1044](#1044)) ([0c7f78a](0c7f78a)) * remove deprecated flags ([#1075](#1075)) ([49f6fe5](49f6fe5)) </details> <details><summary>flagd-proxy: 0.4.0</summary> ## [0.4.0](flagd-proxy/v0.3.2...flagd-proxy/v0.4.0) (2023-12-22) ### ⚠ BREAKING CHANGES * remove deprecated flags ([#1075](#1075)) ### 🐛 Bug Fixes * **deps:** update module github.com/open-feature/flagd/core to v0.7.2 ([#1056](#1056)) ([81e83ea](81e83ea)) * **deps:** update module github.com/spf13/viper to v1.18.0 ([#1060](#1060)) ([9dfa689](9dfa689)) ### 🧹 Chore * refactoring component structure ([#1044](#1044)) ([0c7f78a](0c7f78a)) * remove deprecated flags ([#1075](#1075)) ([49f6fe5](49f6fe5)) </details> <details><summary>core: 0.7.3</summary> ## [0.7.3](core/v0.7.2...core/v0.7.3) (2023-12-22) ### 🐛 Bug Fixes * **deps:** update golang.org/x/exp digest to 6522937 ([#1032](#1032)) ([78b23d2](78b23d2)) * **deps:** update module connectrpc.com/connect to v1.13.0 ([#1070](#1070)) ([63f86ea](63f86ea)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.4.0 ([#1068](#1068)) ([5c5d5ab](5c5d5ab)) * **deps:** update module github.com/open-feature/open-feature-operator to v0.5.2 ([#1059](#1059)) ([cefea3e](cefea3e)) * **deps:** update module google.golang.org/grpc to v1.60.0 ([#1074](#1074)) ([bf3e9d8](bf3e9d8)) * **deps:** update module google.golang.org/grpc to v1.60.1 ([#1092](#1092)) ([5bf1368](5bf1368)) * make sure sync builder is initialized to avoid nil pointer access ([#1076](#1076)) ([ebcd616](ebcd616)) ### ✨ New Features * support new flagd.evaluation and flagd.sync schemas ([#1083](#1083)) ([e9728aa](e9728aa)) ### 🧹 Chore * refactoring component structure ([#1044](#1044)) ([0c7f78a](0c7f78a)) * renaming of evaluation components ([#1064](#1064)) ([d39f31d](d39f31d)) * use client-go library for retrieving FeatureFlag CRs ([#1077](#1077)) ([c86dff0](c86dff0)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to the latest refactoring PR #1044 to avoid a nil pointer access when attempting to read from a kubernetes sync source