feat: Add OTEL default variables by askpt · Pull Request #1812 · open-feature/flagd

askpt · 2025-10-13T20:10:22Z

Signed-off-by: André Silva 2493377+askpt@users.noreply.github.com

This PR

This pull request updates the OpenTelemetry integration in the core module to use the new autoexport package, simplifying configuration and improving compatibility with environment variables. It removes custom gRPC transport credential handling and centralizes exporter setup, making telemetry easier to configure and maintain. Several dependencies are updated to their latest versions, and tests are adjusted to reflect the new configuration logic.

OpenTelemetry Integration Refactor:

Replaced manual OTLP exporter and gRPC credential setup with the new autoexport package, removing custom TLS handling and simplifying trace and metric exporter initialization in core/pkg/telemetry/builder.go. Now, environment variables are used for configuration, and Prometheus is used as a fallback for metrics. [1] [2] [3] [4]
Updated test cases in core/pkg/telemetry/builder_test.go to reflect the new autoexport logic, removing tests for unsupported configurations and ensuring the interceptor is always added. [1] [2]

Dependency Updates:

Updated core dependencies in core/go.mod, including prometheus/client_golang, stretchr/testify, go.opentelemetry.io/otel, and related packages to their latest versions. Added new dependencies for autoexport and related exporters.
Updated various indirect dependencies to newer versions, such as github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp, github.com/cenkalti/backoff/v5, github.com/go-jose/go-jose/v4, and others. [1] [2] [3] [4] [5]

These changes make telemetry setup more robust and future-proof, reducing custom code and leveraging upstream improvements.

Related Issues

Fixes #1141

Notes

In case the "old" variables are set, I override the "auto-export" variables. Then the library do its magic as suggested by @erka

netlify · 2025-10-13T20:10:28Z

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name	Link
🔨 Latest commit	`87a4a69`
🔍 Latest deploy log	https://app.netlify.com/projects/polite-licorice-3db33c/deploys/6932f5cdf8cbe80008140251

erka · 2025-10-14T11:51:10Z

@askpt I would suggest using https://pkg.go.dev/go.opentelemetry.io/contrib/exporters/autoexport and not re-implement the entire otel sdk.

askpt · 2025-10-14T12:59:55Z

@askpt I would suggest using https://pkg.go.dev/go.opentelemetry.io/contrib/exporters/autoexport and not re-implement the entire otel sdk.

Thank you so much for the suggestion @erka! I was not aware of this library, and I will take a look. I am concerned that it may not be easily switched, as we need to maintain backwards compatibility with the previous settings.

erka · 2025-10-14T13:05:40Z

You can likely configure the OTEL environment variables within the code - using the flagd configuration - prior to initializing autoexport to maintain backwards compatibility.

…erride Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

…ation Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

…sistency Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

…uration. Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

beeme1mr · 2025-11-18T15:17:47Z

@askpt I've resolved the FOSSA issues.

askpt · 2025-11-18T15:20:17Z

@askpt I've resolved the FOSSA issues.

@beeme1mr Is there any library i shouldn't be using? I think they are all related to OTEL.

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

toddbaert · 2025-11-21T18:22:03Z

/gemini review

gemini-code-assist

Code Review

This pull request is a significant improvement, refactoring the OpenTelemetry integration to use the autoexport package. This change greatly simplifies the codebase by removing custom logic for OTLP exporter setup and transport credentials, instead relying on standard environment variable-based configuration. The addition of backward compatibility for existing flag-based configurations by setting the corresponding environment variables is a well-thought-out approach. The overall result is a cleaner, more maintainable, and more standard-compliant telemetry setup. The dependency updates and test adjustments are also appropriate and align with the refactoring. Great work!

toddbaert · 2025-11-21T18:59:20Z

It seems right to me, but I'm far from being an OTel expert, especially WRT to the autoexport stuff... maybe @beeme1mr can confrim.

…meters Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

sonarqubecloud · 2025-12-05T15:10:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.13.0</summary> ## [0.13.0](flagd/v0.12.9...flagd/v0.13.0) (2025-12-23) ### 🐛 Bug Fixes * fixing sync return format missing flag layer, adding full e2e suite ([#1827](#1827)) ([570693d](570693d)) * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) ### ✨ New Features * add support for http-based ofrep metrics ([#1803](#1803)) ([fcd19b3](fcd19b3)) * cleanup evaluator interface ([#1793](#1793)) ([aa504f7](aa504f7)) * enable parsing of array flag configurations for flagd ([#1797](#1797)) ([97c6ffa](97c6ffa)) * multi-project support via selectors and flagSetId namespacing ([#1702](#1702)) ([f9ce46f](f9ce46f)) * normalize selector in sync (use header as in OFREP and RPC) ([#1815](#1815)) ([c1f06cb](c1f06cb)) ### 🧹 Chore * **refactor:** use memdb for flag storage ([#1697](#1697)) ([5c5c1cf](5c5c1cf)) ### 🔄 Refactoring * store cleanup ([#1705](#1705)) ([bcff8d7](bcff8d7)) </details> <details><summary>flagd-proxy: 0.8.1</summary> ## [0.8.1](flagd-proxy/v0.8.0...flagd-proxy/v0.8.1) (2025-12-23) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) </details> <details><summary>core: 0.13.0</summary> ## [0.13.0](core/v0.12.1...core/v0.13.0) (2025-12-23) ### ⚠ BREAKING CHANGES * enable parsing of array flag configurations for flagd ([#1797](#1797)) * cleanup evaluator interface ([#1793](#1793)) * removes the `fractionalEvaluation` operator since it has been replaced with `fractional`. ([#1704](#1704)) ### 🐛 Bug Fixes * **security:** update module github.com/go-viper/mapstructure/v2 to v2.4.0 [security] ([#1784](#1784)) ([037e30b](037e30b)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1825](#1825)) ([44edcc9](44edcc9)) * **security:** update module golang.org/x/crypto to v0.45.0 [security] ([#1826](#1826)) ([7e0762b](7e0762b)) ### ✨ New Features * Add OAuth support for HTTP Sync ([#1791](#1791)) ([268fd75](268fd75)) * Add OTEL default variables ([#1812](#1812)) ([c2e3fc6](c2e3fc6)) * allow null flagSetId Selector, restrict Selector to single key-value-pairs ([#1708](#1708)) ([#1811](#1811)) ([c12a0ae](c12a0ae)) * change jsonschema parser ([#1794](#1794)) ([bf3f722](bf3f722)) * cleanup evaluator interface ([#1793](#1793)) ([aa504f7](aa504f7)) * enable parsing of array flag configurations for flagd ([#1797](#1797)) ([97c6ffa](97c6ffa)) * multi-project support via selectors and flagSetId namespacing ([#1702](#1702)) ([f9ce46f](f9ce46f)) ### 🧹 Chore * **refactor:** use memdb for flag storage ([#1697](#1697)) ([5c5c1cf](5c5c1cf)) * removes the `fractionalEvaluation` operator since it has been replaced with `fractional`. ([#1704](#1704)) ([3228ad8](3228ad8)) ### 🔄 Refactoring * remove deprecated bearerToken option ([#1816](#1816)) ([efda06a](efda06a)) * removed unused Selector from Flag and Store. ([#1747](#1747)) ([1083005](1083005)) * store cleanup ([#1705](#1705)) ([bcff8d7](bcff8d7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>

askpt added 7 commits October 23, 2025 14:38

feat: enhance metrics exporter configuration and add collector URI ov…

bffeb6a

…erride Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

feat: add support for OTLP headers and protocol in telemetry configur…

4a84cc7

…ation Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

feat: add timeout configuration and header parsing for OTLP in telemetry

f002fb4

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

refactor: rename buildOtlpExporter to buildGrpcTraceExporter for clarity

76a4da4

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

refactor: rename BuildMetricsRecorder to BuildMetricsProvider for con…

6dd1609

…sistency Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Revert implementation

ab096f2

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

Refactor telemetry builder to use autoexport for OpenTelemetry config…

6d015b6

…uration. Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

askpt marked this pull request as ready for review October 31, 2025 16:16

askpt requested review from a team as code owners October 31, 2025 16:16

dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 31, 2025

Merge branch 'main' into askpt/1141-add-otel-variables

f072826

Merge branch 'main' into askpt/1141-add-otel-variables

0c23f00

Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

gemini-code-assist Bot reviewed Nov 21, 2025

View reviewed changes

Comment thread core/pkg/telemetry/builder.go Outdated

toddbaert reviewed Nov 21, 2025

View reviewed changes

Comment thread core/pkg/telemetry/builder.go

toddbaert requested a review from beeme1mr November 21, 2025 18:56

toddbaert self-requested a review November 21, 2025 18:59

toddbaert approved these changes Nov 21, 2025

View reviewed changes

askpt added 2 commits December 5, 2025 15:06

Merge branch 'main' into askpt/1141-add-otel-variables

dffbe65

refactor(telemetry): update function signatures to ignore unused para…

87a4a69

…meters Signed-off-by: André Silva <2493377+askpt@users.noreply.github.com>

weyert approved these changes Dec 5, 2025

View reviewed changes

beeme1mr approved these changes Dec 8, 2025

View reviewed changes

beeme1mr merged commit c2e3fc6 into open-feature:main Dec 8, 2025
17 checks passed

github-actions Bot mentioned this pull request Dec 2, 2025

chore: release main #1699

Merged

askpt deleted the askpt/1141-add-otel-variables branch December 9, 2025 05:32

erka mentioned this pull request Mar 23, 2026

docs: document custom OTel resource attributes configuration #1910

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add OTEL default variables#1812

feat: Add OTEL default variables#1812
beeme1mr merged 11 commits into
open-feature:mainfrom
askpt:askpt/1141-add-otel-variables

askpt commented Oct 13, 2025 •

edited

Loading

Uh oh!

netlify Bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

erka commented Oct 14, 2025

Uh oh!

askpt commented Oct 14, 2025

Uh oh!

erka commented Oct 14, 2025

Uh oh!

beeme1mr commented Nov 18, 2025

Uh oh!

askpt commented Nov 18, 2025

Uh oh!

toddbaert commented Nov 21, 2025

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Nov 21, 2025 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Dec 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

askpt commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR

Related Issues

Notes

Uh oh!

netlify Bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for polite-licorice-3db33c canceled.

Uh oh!

erka commented Oct 14, 2025

Uh oh!

askpt commented Oct 14, 2025

Uh oh!

erka commented Oct 14, 2025

Uh oh!

beeme1mr commented Nov 18, 2025

Uh oh!

askpt commented Nov 18, 2025

Uh oh!

toddbaert commented Nov 21, 2025

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

toddbaert commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Dec 5, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

askpt commented Oct 13, 2025 •

edited

Loading

netlify Bot commented Oct 13, 2025 •

edited

Loading

toddbaert commented Nov 21, 2025 •

edited

Loading