Skip to content

feat: allow null flagSetId Selector, restrict Selector to single key-value-pairs (#1708)#1811

Merged
toddbaert merged 1 commit into
open-feature:mainfrom
open-feature-forking:feat/nullflagsetid
Oct 15, 2025
Merged

feat: allow null flagSetId Selector, restrict Selector to single key-value-pairs (#1708)#1811
toddbaert merged 1 commit into
open-feature:mainfrom
open-feature-forking:feat/nullflagsetid

Conversation

@alexandraoberaigner

@alexandraoberaigner alexandraoberaigner commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR

This pull request updates the Selector logic in the flag store to allow selecting flags without a flagSetId (flagSetId=).

It also restricts selector expressions to a single key-value pair, and updates / skips related tests. This is a temporary limitation pending a decision on the selector syntax (#1708).

Related Issues

#1708

Follow-up Tasks

TODO: we should decide on the selector syntax

How to test

  • run make run-flagd-selector-demo
  • experiment with queries & flag configurations with/without flagSetIds (be aware that the top level flagSetId is setting the flagSetId for all flags without already exisiting flagSetId):
grpcurl -d '{"selector":"flagSetId=example"}' -import-path schemas/protobuf/flagd/sync/v1/ -proto sync.proto -plaintext localhost:8015 flagd.sync.v1.FlagSyncService/SyncFlags | jq
grpcurl -d '{"selector":"flagSetId="}' -import-path schemas/protobuf/flagd/sync/v1/ -proto sync.proto -plaintext localhost:8015 flagd.sync.v1.FlagSyncService/SyncFlags | jq

@alexandraoberaigner alexandraoberaigner requested review from a team as code owners October 9, 2025 14:50
@alexandraoberaigner alexandraoberaigner changed the title feat: allow null flagSetId Selector, restrict Selector to single key-…(#1708) feat: allow null flagSetId Selector, restrict Selector to single key-value-pairs (#1708) Oct 9, 2025
guidobrei
guidobrei reviewed Oct 9, 2025
View reviewed changes
Comment thread core/pkg/store/store_test.go Outdated
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 9, 2025
@toddbaert

toddbaert commented Oct 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

This looks like the minimum workable implementation until we decide on a more robust Selector syntax. I'm not sure we even want to document this for now, but IMO it's releasable and will allow us to release something now without regretting it.

I'm ready to approve except I agree with @guidobrei 's comment here.

@netlify

netlify Bot commented Oct 13, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for polite-licorice-3db33c canceled.

Name Link
🔨 Latest commit 5afde03
🔍 Latest deploy log https://app.netlify.com/projects/polite-licorice-3db33c/deploys/68efdc598a116b0008d90fce

@toddbaert

toddbaert commented Oct 14, 2025

Copy link
Copy Markdown
Member

I'll merge this tomorrow unless I hear objections.

@alexandraoberaigner @toddbaert
feat: allow null flagSetId Selector, restrict Selector to single key-…
5afde03 
…value pair and update/skip tests (open-feature#1708)

Until we decide on the Selector syntax, only a single key=value pair is supported

Signed-off-by: Alexandra Oberaigner <alexandra.oberaigner@dynatrace.com>
@toddbaert toddbaert merged commit c12a0ae into open-feature:main Oct 15, 2025
15 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 13, 2025
Merged
@toddbaert toddbaert deleted the feat/nullflagsetid branch October 16, 2025 14:51
toddbaert added a commit that referenced this pull request Dec 24, 2025
@github-actions @toddbaert
chore: release main (#1699)
814a6ac 
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.13.0</summary>

##
[0.13.0](flagd/v0.12.9...flagd/v0.13.0)
(2025-12-23)


### 🐛 Bug Fixes

* fixing sync return format missing flag layer, adding full e2e suite
([#1827](#1827))
([570693d](570693d))
* **security:** update module github.com/go-viper/mapstructure/v2 to
v2.4.0 [security]
([#1784](#1784))
([037e30b](037e30b))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1826](#1826))
([7e0762b](7e0762b))


### ✨ New Features

* add support for http-based ofrep metrics
([#1803](#1803))
([fcd19b3](fcd19b3))
* cleanup evaluator interface
([#1793](#1793))
([aa504f7](aa504f7))
* enable parsing of array flag configurations for flagd
([#1797](#1797))
([97c6ffa](97c6ffa))
* multi-project support via selectors and flagSetId namespacing
([#1702](#1702))
([f9ce46f](f9ce46f))
* normalize selector in sync (use header as in OFREP and RPC)
([#1815](#1815))
([c1f06cb](c1f06cb))


### 🧹 Chore

* **refactor:** use memdb for flag storage
([#1697](#1697))
([5c5c1cf](5c5c1cf))


### 🔄 Refactoring

* store cleanup
([#1705](#1705))
([bcff8d7](bcff8d7))
</details>

<details><summary>flagd-proxy: 0.8.1</summary>

##
[0.8.1](flagd-proxy/v0.8.0...flagd-proxy/v0.8.1)
(2025-12-23)


### 🐛 Bug Fixes

* **security:** update module github.com/go-viper/mapstructure/v2 to
v2.4.0 [security]
([#1784](#1784))
([037e30b](037e30b))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1826](#1826))
([7e0762b](7e0762b))
</details>

<details><summary>core: 0.13.0</summary>

##
[0.13.0](core/v0.12.1...core/v0.13.0)
(2025-12-23)


### ⚠ BREAKING CHANGES

* enable parsing of array flag configurations for flagd
([#1797](#1797))
* cleanup evaluator interface
([#1793](#1793))
* removes the `fractionalEvaluation` operator since it has been replaced
with `fractional`.
([#1704](#1704))

### 🐛 Bug Fixes

* **security:** update module github.com/go-viper/mapstructure/v2 to
v2.4.0 [security]
([#1784](#1784))
([037e30b](037e30b))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1825](#1825))
([44edcc9](44edcc9))
* **security:** update module golang.org/x/crypto to v0.45.0 [security]
([#1826](#1826))
([7e0762b](7e0762b))


### ✨ New Features

* Add OAuth support for HTTP Sync
([#1791](#1791))
([268fd75](268fd75))
* Add OTEL default variables
([#1812](#1812))
([c2e3fc6](c2e3fc6))
* allow null flagSetId Selector, restrict Selector to single
key-value-pairs
([#1708](#1708))
([#1811](#1811))
([c12a0ae](c12a0ae))
* change jsonschema parser
([#1794](#1794))
([bf3f722](bf3f722))
* cleanup evaluator interface
([#1793](#1793))
([aa504f7](aa504f7))
* enable parsing of array flag configurations for flagd
([#1797](#1797))
([97c6ffa](97c6ffa))
* multi-project support via selectors and flagSetId namespacing
([#1702](#1702))
([f9ce46f](f9ce46f))


### 🧹 Chore

* **refactor:** use memdb for flag storage
([#1697](#1697))
([5c5c1cf](5c5c1cf))
* removes the `fractionalEvaluation` operator since it has been replaced
with `fractional`.
([#1704](#1704))
([3228ad8](3228ad8))


### 🔄 Refactoring

* remove deprecated bearerToken option
([#1816](#1816))
([efda06a](efda06a))
* removed unused Selector from Flag and Store.
([#1747](#1747))
([1083005](1083005))
* store cleanup
([#1705](#1705))
([bcff8d7](bcff8d7))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert toddbaert approved these changes

+2 more reviewers

@chrfwow chrfwow chrfwow approved these changes

@guidobrei guidobrei guidobrei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexandraoberaigner @toddbaert @beeme1mr @chrfwow @guidobrei