fix(cli): fixup / refactor filesystem config handling#615
Merged
jakobmoellerdev merged 4 commits intoAug 25, 2025
Merged
Conversation
#### What this PR does / why we need it - Refactored working directory handling - Improved CLI flag precedence logic to ensure CLI flag values override other configurations effectively. - Removed hooks and builder logic to reduce complexity and redundancy. - Enhanced unit test to validate new working directory and filesystem setup logic is actually set in filesystem context These changes improve reliability and simplify the implementation of filesystem configuration while ensuring proper value precedence and behavior. They also fixed a bug in the filesystem config defaulting not applying to the context Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
5e2755d to
6d01077
Compare
- Migrated `filesystem configuration` to the global `Scheme` introduced in the configuration package. - Replaced local scheme initialization with `configuration.Scheme`. - Updated defaulting and conversion logic to leverage the centralized `Scheme` for runtime types. - Dependency updated: `configuration` package to `v0.0.7` for global scheme support. This change unifies runtime type handling and simplifies scheme integration by using the shared global scheme. Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
9ef3d57 to
9190e4e
Compare
Skarlso
approved these changes
Aug 25, 2025
jakobmoellerdev
pushed a commit
that referenced
this pull request
Sep 1, 2025
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it ocm get cv fails with components in oci registries without specifying port. for urls like `ghcr.io` in `ocm get cv` the `credentialCache` fails due to using `net.SplitHostPort` on the url without a port. This PR adds a fallback to 443 in those cases and updates the tests. #### Which issue(s) this PR fixes Fixes #615 --------- Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
These changes improve reliability and simplify the implementation of filesystem configuration while ensuring proper value precedence and behavior. They also fixed a bug in the filesystem config defaulting not applying to the context.
Which issue(s) this PR fixes
follow up to #591