fix(615): ocm get cv fails#753
Merged
jakobmoellerdev merged 6 commits intoSep 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where ocm get cv fails by improving the handling of host:port parsing in the credential cache. The main change adds proper error handling for cases where a host is provided without a port number, defaulting to port 443 in such scenarios.
- Enhanced credential cache to handle hosts without explicit ports by defaulting to port 443
- Added proper error checking using
errors.Asto identify address parsing errors - Updated wordlist with various technical terms
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| bindings/go/oci/repository/provider/credential_cache.go | Added error handling for host:port parsing with default port fallback |
| .github/config/wordlist.txt | Added various technical terms to the allowed wordlist |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8f54808 to
4d7a908
Compare
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
matthiasbruns
commented
Aug 30, 2025
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
On-behalf-of: SAP <matthias.bruns@sap.com> Signed-off-by: Matthias Bruns <git@matthiasbruns.com>
…open-component-model into fix/615-ocm-get-cv-failsa
jakobmoellerdev
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
ocm get cv fails with components in oci registries without specifying port.
for urls like
ghcr.ioinocm get cvthecredentialCachefails due to usingnet.SplitHostPorton the url without a port.This PR adds a fallback to 443 in those cases and updates the tests.
Which issue(s) this PR fixes
Fixes #615