feat: setup helm blob transformer that can extract OCI layouts#530
Merged
Skarlso merged 17 commits intoAug 27, 2025
Merged
Conversation
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Member
Author
|
While implementing I noticed the file names need to be made dynamic based on evaluating the OCM Image Config. Otherwise we cannot make dynamic names for helm charts a thing, which is unfortunately a must to properly get HELM charts to work. This is because if a helm chart is named differently from its declared name / version, helm CLI / lib will break |
…figs # Conflicts: # bindings/go/configuration/extract/v1alpha1/spec/config.go
b371029 to
dfafad1
Compare
…figs Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
dfafad1 to
d4ddf54
Compare
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
…figs Signed-off-by: Jakob Möller <jakob.moeller@sap.com> # Conflicts: # cli/go.mod # cli/go.sum
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
jakobmoellerdev
added a commit
that referenced
this pull request
Aug 18, 2025
… updates (#585) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it - Add fallback logic to derive media type from blob if not specified in local blob access. - Ensure descriptor digest is initialized when updating local blob resource for descriptor accuracy. - Enhance test coverage for blob media type handling and descriptor updates. #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> relates to findings on testing with #530 causing integratio ntests to fail --------- Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
- Updated `ocm.software/open-component-model/bindings/go/oci` to version `v0.0.6`. Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
9aa6cd5 to
7bd510a
Compare
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
7bd510a to
b76c2ad
Compare
440ddae to
661dc52
Compare
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
661dc52 to
18cbe44
Compare
fabianburth
previously approved these changes
Aug 22, 2025
…figs Signed-off-by: Jakob Möller <jakob.moeller@sap.com> # Conflicts: # Taskfile.yml # bindings/go/helm/go.mod # bindings/go/helm/go.sum # cli/cmd/setup/setup.go # cli/go.mod # cli/go.sum # cli/integration/go.mod # cli/integration/go.sum
40fb15c to
340d3ec
Compare
Member
Author
|
The major issue I have right now is that there is no way to get transformer configs by ID from the central .ocmconfig. I think for now this is fine but this means there is no customizeability. |
Signed-off-by: Jakob Möller <jakob.moeller@sap.com>
fabianburth
reviewed
Aug 26, 2025
fabianburth
approved these changes
Aug 26, 2025
fabianburth
left a comment
Contributor
There was a problem hiding this comment.
If it does not exist yet, please create a follow up issue to get transformer configs by ID from the central .ocmconfig.
Skarlso
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This finally introduces an automatic HELM blob transformer
Which issue(s) this PR fixes
Once merged fixes open-component-model/ocm-project#553 by allowing
ocm download resource --transformer helmto fully automatically return the helm chart natively.