Skip to content

feat(scheme): expose scheme retrieval methods in various components#1268

Merged
fabianburth merged 4 commits into
open-component-model:mainfrom
fabianburth:feat/expose-scheme
Nov 27, 2025
Merged

feat(scheme): expose scheme retrieval methods in various components#1268
fabianburth merged 4 commits into
open-component-model:mainfrom
fabianburth:feat/expose-scheme

Conversation

@fabianburth

@fabianburth fabianburth commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Added methods to retrieve the runtime scheme in multiple components, preparing for simpler internal plugin registration.

If you feel like you are lacking context for some of the changes in this PR, it is part of this larger PR.

Which issue(s) this PR fixes

Contributes to open-component-model/ocm-project#761

@fabianburth fabianburth requested a review from a team as a code owner November 26, 2025 21:26
@github-actions github-actions Bot added kind/feature new feature, enhancement, improvement, extension size/m Medium labels Nov 26, 2025
Added methods to retrieve the runtime scheme in multiple components,
preparing for simpler internal plugin registration.

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Updated the OCI bindings to the latest version to ensure compatibility and access to new features.

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Introduce Builtin interfaces to allow plugin registries to register
internal plugins without requiring callers to explicitly provide a
scheme with their supported types.

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
@fabianburth

Copy link
Copy Markdown
Contributor Author

added some documentation to the builtin interfaces

@matthiasbruns matthiasbruns left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fabianburth fabianburth merged commit 071969b into open-component-model:main Nov 27, 2025
56 checks passed
@fabianburth fabianburth deleted the feat/expose-scheme branch November 27, 2025 11:32
jakobmoellerdev added a commit that referenced this pull request Nov 28, 2025
<!-- markdownlint-disable MD041 -->
#### What this PR does / why we need it
Refactor the registration methods for internal plugins to use a more
consistent and streamlined approach. This change enhances readability
and maintainability by reducing redundancy in the code.

This is what the changes in this previous
[PR](#1268)
were needed for.

**Notes for the Reviewers**
The changes are quite repetitive. But pay special attention to the
registration method of input.

#### Which issue(s) this PR fixes
<!--
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->
Contributes to
open-component-model/ocm-project#761

---------

Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Co-authored-by: Jakob Möller <jakob.moeller@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature new feature, enhancement, improvement, extension size/m Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants