feat(provider): simplify internal plugin registration#1228
Closed
fabianburth wants to merge 14 commits into
Closed
feat(provider): simplify internal plugin registration#1228fabianburth wants to merge 14 commits into
fabianburth wants to merge 14 commits into
Conversation
bc451cf to
560d619
Compare
This method allows retrieval of the component version repository scheme for simplifying plugin registry registration. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This method allows retrieval of the resource repository scheme from the plugin itself for simplifying plugin registry registration. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
560d619 to
5247399
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This change introduces the GetSigningHandlerScheme method to the pluginConverter and Handler types, allowing retrieval of the associated runtime scheme. Additionally, the RegisterInternalComponentSignatureHandler method has been updated to utilize the new method for improved plugin registration. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
…thodScheme methods This update introduces new methods to retrieve the input method schemes for resources and sources, enhancing the flexibility of input handling in the provider. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Renamed GetResourceInputMethodScheme and GetSourceInputMethodScheme to GetInputMethodScheme for consistency across the provider interface. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This method allows retrieval of the resource repository scheme from the digest processor plugin, enhancing the plugin's capabilities for resource management. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This method provides a new way to retrieve the credential repository scheme for plugins, enhancing the flexibility of credential management. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
This method allows retrieval of the component version repository scheme, enhancing the functionality of the component lister registry. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Implement GetTransformerScheme method in multiple files to provide a unified way to retrieve the transformer scheme. Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Contributor
Author
|
I discussed with @jakobmoellerdev that we thin external plugin converters might never need a scheme (as we cannot know their go types anyway). |
cdbfabf to
d241c48
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
d241c48 to
27a0bbf
Compare
Signed-off-by: Fabian Burth <fabian.burth@sap.com>
Contributor
Author
|
This PR is essentially ready for review. I will just have to factor it out into pull requests for the individual dependent modules. |
fabianburth
added a commit
that referenced
this pull request
Nov 27, 2025
…1268) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Added methods to retrieve the runtime scheme in multiple components, preparing for simpler internal plugin registration. If you feel like you are lacking context for some of the changes in this PR, it is part of this larger [PR](#1228). #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Contributes to open-component-model/ocm-project#761 --------- Signed-off-by: Fabian Burth <fabian.burth@sap.com>
# Conflicts: # bindings/go/plugin/manager/registries/blobtransformer/contract.go # bindings/go/plugin/manager/registries/componentlister/contract.go # bindings/go/plugin/manager/registries/componentversionrepository/contract.go # bindings/go/plugin/manager/registries/credentialrepository/contract.go # bindings/go/plugin/manager/registries/digestprocessor/contract.go # bindings/go/plugin/manager/registries/input/contract.go # bindings/go/plugin/manager/registries/resource/contract.go # bindings/go/plugin/manager/registries/signinghandler/contract.go
Contributor
Author
|
Completed with other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This pull requests adjust the internal plugin registration implementation to fetch the types from the provider instead of having to provide the types explicitly.
Which issue(s) this PR fixes
open-component-model/ocm-project#761