Clarify behavior in ConvTranspose#2343
Merged
wschin merged 4 commits intoonnx:masterfrom Sep 21, 2019
Merged
Conversation
fdwr
reviewed
Sep 20, 2019
adtsai
reviewed
Sep 20, 2019
adtsai
approved these changes
Sep 20, 2019
ebarsoum
approved these changes
Sep 21, 2019
kevinch-nv
pushed a commit
that referenced
this pull request
Sep 23, 2019
* Gemm optional bias (#2330) * Made the 'C' input of Gemm (the bias term) optional. If missing it defaults to 0. Also added a test case for no bias. Updated the Gemm op to version 11. * Fixed a typo! * Small tweaks to the Gemm docs. * Added a shape inference test for Gemm with no bias * Tweaked coding style slightly by adding braces to single line scopes. * Fix some backend tests (#2335) * Fix some node tests * PR comments and docs * Update Changelog.md * Update gen_doc script to validate proto3 files (#2122) * Update gen_doc script to validate proto3 files * Update CMakeLists.txt * Update pybind (#2340) * Fix node test case model for Gemm scalar bias case (#2342) * Fix some node tests * PR comments and docs * Update Changelog.md * Fix gemm scalar node test * Clarify behavior in ConvTranspose (#2343) * Fix the wrong behavior in ConvTranspose * Address comments
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Fix the wrong behavior in ConvTranspose * Address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the wording for
output_paddingattribute in ConvTranspose clearer. Since the version number of ConvTranspose in ONNX-1.5 is still 1, this PR doesn't touch ConvTranspose's version number. That is, the ConvTranspose is still in opset 11. Note that since Tensorflow doesn't useoutput_padding, this attribute is mainly for matching Pytorch's behavior.Pytorch reference. Tensorflow reference.
This PR should fix #2333.