Update gen_doc script to validate proto3 files#2122
Merged
wschin merged 7 commits intoonnx:masterfrom Sep 19, 2019
Merged
Conversation
linkerzhang
approved these changes
Jun 25, 2019
linkerzhang
reviewed
Jun 25, 2019
Member
linkerzhang
left a comment
There was a problem hiding this comment.
Can this be added in CI kind of as a test case instead of being added in gen_doc.py?
Contributor
Author
|
I added this into windows CI already. Any changes breaks the protoc compilation will be blocked |
|
|
Member
|
@raymondxyang could you sign the CLA? |
Contributor
|
Raymond left Microsoft. So, we may need to duplicate this, if we want to merge this in. |
wschin
approved these changes
Sep 19, 2019
kevinch-nv
pushed a commit
that referenced
this pull request
Sep 23, 2019
* Gemm optional bias (#2330) * Made the 'C' input of Gemm (the bias term) optional. If missing it defaults to 0. Also added a test case for no bias. Updated the Gemm op to version 11. * Fixed a typo! * Small tweaks to the Gemm docs. * Added a shape inference test for Gemm with no bias * Tweaked coding style slightly by adding braces to single line scopes. * Fix some backend tests (#2335) * Fix some node tests * PR comments and docs * Update Changelog.md * Update gen_doc script to validate proto3 files (#2122) * Update gen_doc script to validate proto3 files * Update CMakeLists.txt * Update pybind (#2340) * Fix node test case model for Gemm scalar bias case (#2342) * Fix some node tests * PR comments and docs * Update Changelog.md * Fix gemm scalar node test * Clarify behavior in ConvTranspose (#2343) * Fix the wrong behavior in ConvTranspose * Address comments
Member
|
Thanks a lot @raymondxyang |
jcwchen
pushed a commit
to jcwchen/onnx
that referenced
this pull request
Sep 23, 2020
* Update gen_doc script to validate proto3 files * Update CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a step in gen_doc.py to validate the generated proto3 files by using them to generate the .cc .h code.
This step will only be triggered when ONNX_VERIFY_PROTO3 is set to true in CI env.