Skip to content

feat: Price Feeder in Ojo node#386

Merged
rbajollari merged 9 commits intotiafrom
ryan/price-feeder-package
Feb 22, 2024
Merged

feat: Price Feeder in Ojo node#386
rbajollari merged 9 commits intotiafrom
ryan/price-feeder-package

Conversation

@rbajollari
Copy link
Copy Markdown
Member

@rbajollari rbajollari commented Feb 21, 2024

Description

closes: #XXXX

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (tia@8649e17). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@          Coverage Diff           @@
##             tia     #386   +/-   ##
======================================
  Coverage       ?   16.08%           
======================================
  Files          ?       78           
  Lines          ?    18785           
  Branches       ?        0           
======================================
  Hits           ?     3022           
  Misses         ?    15596           
  Partials       ?      167

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbajollari rbajollari marked this pull request as ready for review February 21, 2024 23:16
@rbajollari rbajollari requested a review from a team as a code owner February 21, 2024 23:16
adamewozniak
adamewozniak approved these changes Feb 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple nits

rbajollari and others added 4 commits February 21, 2024 18:26
@rbajollari
comments
fe28bc7
@rbajollari @adamewozniak
Update pricefeeder/price-feeder.example.toml
c54c678 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@rbajollari @adamewozniak
Update pricefeeder/price-feeder.example.toml
f821fa4 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@rbajollari
pf import
addd60f
@rbajollari rbajollari merged commit 7ffb8b5 into tia Feb 22, 2024
@rbajollari rbajollari deleted the ryan/price-feeder-package branch February 22, 2024 00:08
@rbajollari
Copy link
Copy Markdown
Member Author

rbajollari commented Feb 29, 2024

@Mergifyio backport main

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 29, 2024 •
edited
Loading

backport main

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Feb 29, 2024
@rbajollari @mergify
feat: Price Feeder in Ojo node (#386)
1cc3d9b 
(cherry picked from commit 7ffb8b5)

# Conflicts:
#	go.mod
#	go.sum
@mergify mergify bot mentioned this pull request Feb 29, 2024
Merged
rbajollari added a commit that referenced this pull request Mar 1, 2024
@rbajollari
feat: Price Feeder in Ojo node (#386)
1d6065b 
(cherry picked from commit 7ffb8b5)

# Conflicts:
#	go.mod
#	go.sum
rbajollari added a commit that referenced this pull request Mar 1, 2024
@mergify @rbajollari
feat: Price Feeder in Ojo node (backport #386) (#392)
b7b69e7 
* feat: Price Feeder in Ojo node (#386)

(cherry picked from commit 7ffb8b5)

# Conflicts:
#	go.mod
#	go.sum

* merge conflicts

* make oracle tick time env var

---------

Co-authored-by: ryanbajollari <54822716+rbajollari@users.noreply.github.com>
Co-authored-by: rbajollari <rbajollari@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamewozniak adamewozniak adamewozniak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rbajollari @codecov-commenter @adamewozniak