Skip to content

feat: Price Feeder in Ojo node (backport #386)#392

Merged
rbajollari merged 3 commits intomainfrom
mergify/bp/main/pr-386
Mar 1, 2024
Merged

feat: Price Feeder in Ojo node (backport #386)#392
rbajollari merged 3 commits intomainfrom
mergify/bp/main/pr-386

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Feb 29, 2024

This is an automatic backport of pull request #386 done by Mergify.
Cherry-pick of 7ffb8b5 has failed:

On branch mergify/bp/main/pr-386
Your branch is up to date with 'origin/main'.

You are currently cherry-picking commit 7ffb8b5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cmd/ojod/cmd/commands.go
	new file:   pricefeeder/price-feeder.example.toml
	new file:   pricefeeder/pricefeeder.go
	modified:   scripts/init-local.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the conflicts label Feb 29, 2024
@mergify mergify bot requested a review from a team as a code owner February 29, 2024 22:35
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Feb 29, 2024

Cherry-pick of 7ffb8b5 has failed:

On branch mergify/bp/main/pr-386
Your branch is up to date with 'origin/main'.

You are currently cherry-picking commit 7ffb8b5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cmd/ojod/cmd/commands.go
	new file:   pricefeeder/price-feeder.example.toml
	new file:   pricefeeder/pricefeeder.go
	modified:   scripts/init-local.sh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Feb 29, 2024
17 tasks
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.06%. Comparing base (eda6721) to head (adf259c).
Report is 6 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   16.10%   16.06%   -0.04%     
==========================================
  Files          78       78              
  Lines       18770    18781      +11     
==========================================
- Hits         3022     3018       -4     
- Misses      15595    15596       +1     
- Partials      153      167      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +122 to +132
go func() {
sig := <-sigCh
logger.Info().Str("signal", sig.String()).Msg("caught signal; shutting down...")
cancel()
}()

Check notice

Code scanning / CodeQL

Spawning a Go routine

Spawning a Go routine may be a possible source of non-determinism
Comment on lines +160 to +169
go func() {
logger.Info().Str("listen_addr", cfg.Server.ListenAddr).Msg("starting price-feeder server...")
srvErrCh <- srv.ListenAndServe()
}()

Check notice

Code scanning / CodeQL

Spawning a Go routine

Spawning a Go routine may be a possible source of non-determinism
Comment on lines +196 to +205
go func() {
logger.Info().Msg("starting price-feeder oracle...")
srvErrCh <- oracle.StartClientless(ctx, oracleParams, tickSleep)
}()

Check notice

Code scanning / CodeQL

Spawning a Go routine

Spawning a Go routine may be a possible source of non-determinism
@rbajollari rbajollari closed this Mar 1, 2024
@rbajollari rbajollari reopened this Mar 1, 2024
Comment on lines +210 to +215
go func() {
err := pricefeeder.Start(oracleGenState.Params)
if err != nil {
panic(err)
}
}()

Check notice

Code scanning / CodeQL

Spawning a Go routine

Spawning a Go routine may be a possible source of non-determinism
rbajollari and others added 3 commits March 1, 2024 10:59
@rbajollari rbajollari force-pushed the mergify/bp/main/pr-386 branch from adf259c to 5932b11 Compare March 1, 2024 17:59
@rbajollari rbajollari merged commit b7b69e7 into main Mar 1, 2024
@rbajollari rbajollari deleted the mergify/bp/main/pr-386 branch March 1, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants