Skip to content

[FW][FIX] stock: couldn't unreserve mixed tracking stock#90976

Closed
fw-bot wants to merge 1 commit intoodoo:saas-15.1from
odoo-dev:saas-15.1-15.0-fix-mix-reservation-arm-tjtk-fw
Closed

[FW][FIX] stock: couldn't unreserve mixed tracking stock#90976
fw-bot wants to merge 1 commit intoodoo:saas-15.1from
odoo-dev:saas-15.1-15.0-fix-mix-reservation-arm-tjtk-fw

Conversation

@fw-bot
Copy link
Copy Markdown
Contributor

@fw-bot fw-bot commented May 10, 2022

  • Install stock

  • Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"

  • Create a Product tracked By Lots (i.e. Product X)

  • Go to Inventory > Operations > Inventory Adjustments

  • Create an Inventory Adjustment for Product X:

    Product | Location | Lot/SN | Real Quantity


Product X  |   WH/Stock   |   LOT 01   |       20
Product X  |   WH/Stock   |            |       10
  • Validate Inventory
  • Go to Inventory > Operations > Transfers and create one:
    • Source Location: WH/Stock
    • Destination Location: WH/Stock/Shelf1
    • Operation Type: Internal Transfers
    • Operations:
      [Product: Product X, Initial Demand: 25]
  • Save Transfer, Mark As Todo and Check availability
  • Click on list icon of Operation line for Product X to display Detailed Operations
  • 20 units of LOT 01 and 5 units without lot have been reserved
  • Set LOT 01 for the 5 reserved units without lot and confirm
  • Open Detailed Operations again
  • There are now 20 units of LOT 01 and 5 units of LOT 01
  • Remove the row with 5 units and confirm
  • Check availability and open Detailed Operation
  • There is now only a row with 25 reserved units of LOT 01
  • Unreserve
    The following errror is raised:
    "It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close #64497

closes #66029

X-original-commit: 217c76b
Signed-off-by: Arnold Moyaux amoyaux@users.noreply.github.com

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #90633

@robodoo
Copy link
Copy Markdown
Contributor

robodoo commented May 10, 2022

Pull request status dashboard

@fw-bot
Copy link
Copy Markdown
Contributor Author

fw-bot commented May 10, 2022

Ping @amoyaux cherrypicking of pull request #90633 failed.

stderr:

14:14:54.022231 git.c:344               trace: built-in: git cherry-pick ea9d0e2e3dfd157d3b2d536d0172a0f8c599eb29
error: could not apply ea9d0e2e3df... [FIX] stock: couldn't unreserve mixed tracking stock
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels May 10, 2022
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label May 10, 2022
@DavidFesquet DavidFesquet force-pushed the saas-15.1-15.0-fix-mix-reservation-arm-tjtk-fw branch from 884c5a5 to 288faf8 Compare May 16, 2022 10:37
@C3POdoo C3POdoo requested a review from a team May 16, 2022 10:48
@DavidFesquet DavidFesquet force-pushed the saas-15.1-15.0-fix-mix-reservation-arm-tjtk-fw branch from 288faf8 to e0d2156 Compare May 17, 2022 11:23
- Install stock
- Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"
- Create a Product tracked By Lots (i.e. Product X)
- Go to Inventory > Operations > Inventory Adjustments
- Create an Inventory Adjustment for Product X:

     Product   |   Location   |   Lot/SN   |   Real Quantity
 -------------------------------------------------------------
    Product X  |   WH/Stock   |   LOT 01   |       20
    Product X  |   WH/Stock   |            |       10

- Validate Inventory
- Go to Inventory > Operations > Transfers and create one:
  * Source Location: WH/Stock
  * Destination Location: WH/Stock/Shelf1
  * Operation Type: Internal Transfers
  * Operations:
    [Product: Product X, Initial Demand: 25]
- Save Transfer, Mark As Todo and Check availability
- Click on list icon of Operation line for Product X to display Detailed Operations
- 20 units of LOT 01 and 5 units without lot have been reserved
- Set LOT 01 for the 5 reserved units without lot and confirm
- Open Detailed Operations again
- There are now 20 units of LOT 01 and 5 units of LOT 01
- Remove the row with 5 units and confirm
- Check availability and open Detailed Operation
- There is now only a row with 25 reserved units of LOT 01
- Unreserve
The following errror is raised:
"It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close odoo#64497

closes odoo#66029

X-original-commit: b5d1614
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
@DavidFesquet DavidFesquet force-pushed the saas-15.1-15.0-fix-mix-reservation-arm-tjtk-fw branch from e0d2156 to 338508e Compare May 18, 2022 06:28
@amoyaux
Copy link
Copy Markdown
Contributor

amoyaux commented May 18, 2022

robodoo r+

robodoo pushed a commit that referenced this pull request May 18, 2022
- Install stock
- Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"
- Create a Product tracked By Lots (i.e. Product X)
- Go to Inventory > Operations > Inventory Adjustments
- Create an Inventory Adjustment for Product X:

     Product   |   Location   |   Lot/SN   |   Real Quantity
 -------------------------------------------------------------
    Product X  |   WH/Stock   |   LOT 01   |       20
    Product X  |   WH/Stock   |            |       10

- Validate Inventory
- Go to Inventory > Operations > Transfers and create one:
  * Source Location: WH/Stock
  * Destination Location: WH/Stock/Shelf1
  * Operation Type: Internal Transfers
  * Operations:
    [Product: Product X, Initial Demand: 25]
- Save Transfer, Mark As Todo and Check availability
- Click on list icon of Operation line for Product X to display Detailed Operations
- 20 units of LOT 01 and 5 units without lot have been reserved
- Set LOT 01 for the 5 reserved units without lot and confirm
- Open Detailed Operations again
- There are now 20 units of LOT 01 and 5 units of LOT 01
- Remove the row with 5 units and confirm
- Check availability and open Detailed Operation
- There is now only a row with 25 reserved units of LOT 01
- Unreserve
The following errror is raised:
"It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close #64497

closes #66029

closes #90976

X-original-commit: b5d1614
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Arnold Moyaux <arm@odoo.com>
@robodoo robodoo closed this May 18, 2022
@robodoo robodoo temporarily deployed to merge May 18, 2022 08:53 Inactive
@fw-bot fw-bot deleted the saas-15.1-15.0-fix-mix-reservation-arm-tjtk-fw branch June 1, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants