[FIX] stock: couldn't unreserve mixed tracking stock by amoyaux · Pull Request #90633 · odoo/odoo

amoyaux · 2022-05-05T13:52:07Z

Install stock
Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations"
Create a Product tracked By Lots (i.e. Product X)
Go to Inventory > Operations > Inventory Adjustments
Create an Inventory Adjustment for Product X:

Product | Location | Lot/SN | Real Quantity

Product X  |   WH/Stock   |   LOT 01   |       20
Product X  |   WH/Stock   |            |       10

Validate Inventory
Go to Inventory > Operations > Transfers and create one:
- Source Location: WH/Stock
- Destination Location: WH/Stock/Shelf1
- Operation Type: Internal Transfers
- Operations:
  [Product: Product X, Initial Demand: 25]
Save Transfer, Mark As Todo and Check availability
Click on list icon of Operation line for Product X to display Detailed Operations
20 units of LOT 01 and 5 units without lot have been reserved
Set LOT 01 for the 5 reserved units without lot and confirm
Open Detailed Operations again
There are now 20 units of LOT 01 and 5 units of LOT 01
Remove the row with 5 units and confirm
Check availability and open Detailed Operation
There is now only a row with 25 reserved units of LOT 01
Unreserve
The following errror is raised:
"It is not possible to unreserve more products of P than you have in stock."

It happens because the system is not able to manage quants with lots and
wihtout lots at the same time. When modifying the move line to 25
reserved units. It's composed of 20 quants with lot and 5 quants without
lot. And when unreserving it will check if there is a quants with 25
units with the lot and if it's not found 25 units without lot. But never
25 units of quants with lots and without lots.

opw-2419444

Close #64497

closes #66029

X-original-commit: 217c76b
Signed-off-by: Arnold Moyaux amoyaux@users.noreply.github.com

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

robodoo · 2022-05-05T13:53:07Z

DavidFesquet · 2022-05-09T09:47:38Z

addons/stock/models/stock_quant.py

Copied from v.14 code.
Not sorting on the lot is what made the tests failed.

- Install stock - Go to Inventory > Configuration > Settings and enable "Lots" and "Storage Locations" - Create a Product tracked By Lots (i.e. Product X) - Go to Inventory > Operations > Inventory Adjustments - Create an Inventory Adjustment for Product X: Product | Location | Lot/SN | Real Quantity ------------------------------------------------------------- Product X | WH/Stock | LOT 01 | 20 Product X | WH/Stock | | 10 - Validate Inventory - Go to Inventory > Operations > Transfers and create one: * Source Location: WH/Stock * Destination Location: WH/Stock/Shelf1 * Operation Type: Internal Transfers * Operations: [Product: Product X, Initial Demand: 25] - Save Transfer, Mark As Todo and Check availability - Click on list icon of Operation line for Product X to display Detailed Operations - 20 units of LOT 01 and 5 units without lot have been reserved - Set LOT 01 for the 5 reserved units without lot and confirm - Open Detailed Operations again - There are now 20 units of LOT 01 and 5 units of LOT 01 - Remove the row with 5 units and confirm - Check availability and open Detailed Operation - There is now only a row with 25 reserved units of LOT 01 - Unreserve The following errror is raised: "It is not possible to unreserve more products of P than you have in stock." It happens because the system is not able to manage quants with lots and wihtout lots at the same time. When modifying the move line to 25 reserved units. It's composed of 20 quants with lot and 5 quants without lot. And when unreserving it will check if there is a quants with 25 units with the lot and if it's not found 25 units without lot. But never 25 units of quants with lots and without lots. opw-2419444 Close odoo#64497 closes odoo#66029 X-original-commit: 217c76b Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>

DavidFesquet · 2022-05-10T09:17:37Z

addons/stock/models/stock_quant.py

        if quants:
            # see _acquire_one_job for explanations
-            self._cr.execute("SELECT id FROM stock_quant WHERE id IN %s LIMIT 1 FOR NO KEY UPDATE SKIP LOCKED", [tuple(quants.ids)])
+            self._cr.execute("SELECT id FROM stock_quant WHERE id IN %s ORDER BY lot_id LIMIT 1 FOR NO KEY UPDATE SKIP LOCKED", [tuple(quants.ids)])


This SQL query did not exist in v.14.
ORDER BY lot_id recreate the sort made by the _gather() method

amoyaux · 2022-05-10T11:09:06Z

robodoo r+

fw-bot · 2022-05-14T05:53:04Z