Skip to content

PRs: add informations#336

Merged
tmcgilchrist merged 3 commits intoocurrent:masterfrom
tmcgilchrist:pr_info
Jun 1, 2022
Merged

PRs: add informations#336
tmcgilchrist merged 3 commits intoocurrent:masterfrom
tmcgilchrist:pr_info

Conversation

@tmcgilchrist
Copy link
Copy Markdown
Member

Found this change on @TheLortex 's fork being used in mirage-ci.

@TheLortex
Copy link
Copy Markdown

Yes so that rationale is that we wanted more information when watching PRs, so Ref.t has been updated to provide a pr_info record.

The problem is that head_of takes a Ref.t for input so I have a second commit (in this branch https://github.com/TheLortex/ocurrent/tree/pr-info) to introduce a Ref.id with the original Ref type.

@tmcgilchrist tmcgilchrist requested a review from TheLortex May 6, 2022 00:06
@TheLortex
Copy link
Copy Markdown

Sorry for reviewing so long after you made your update. This looks good to me but the PR has to be rebased on top of master.

@tmcgilchrist tmcgilchrist merged commit f723dff into ocurrent:master Jun 1, 2022
@tmcgilchrist tmcgilchrist deleted the pr_info branch June 1, 2022 23:07
tmcgilchrist added a commit to tmcgilchrist/opam-repository that referenced this pull request Jun 2, 2022
…, current_github, current_git, current_examples, current_docker and current (0.6.1)

CHANGES:

Web UI:

- UI restyle, embed files using ocaml-crunch. (@ewanmellor, @MisterDA, ocurrent/ocurrent#315)

- Automatically refresh some pipeline pages. (@MisterDA, ocurrent/ocurrent#227)

- Allow to import and export using CSV the log rules. (@MisterDA, ocurrent/ocurrent#327)

- Log matcher takes the pattern with the highest score (@kit-ty-kate, ocurrent/ocurrent#335)

API:

- GitHub: Add pp_short for commit and fix url link for GH commits. (@tmcgilchrist, ocurrent/ocurrent#347)

- GitHub: Fetch commit messages for commits on GitHub (@punchagan, ocurrent/ocurrent#337)

- GitHub: Add Current_github.Api.cmdliner_opt. (@dra27, ocurrent/ocurrent#338)

- GitHub: Add extra PR information to Ref.t (@tmcgilchrist @TheLortex, ocurrent/ocurrent#336)

Plugins:

- GitLab: support GitLab clone fork and fetch MR branch. (@MisterDA, ocurrent/ocurrent#346)

- Git: Fix handling of git repositories with submodules. (@talex5, ocurrent/ocurrent#345)

- GitLab: Fix ref filtering bug for GitLab (@tmcgilchrist, ocurrent/ocurrent#332)

Other:

- Add missing dependencies on Unix (@dra27, ocurrent/ocurrent#331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants