Import and export rules from the web UI#327
Merged
tmcgilchrist merged 2 commits intoocurrent:masterfrom Apr 22, 2022
Merged
Conversation
9d38596 to
f6bb436
Compare
Member
|
Importing atomically seems the right option and clearly report which rules failed the validation. |
77b4033 to
234c7e7
Compare
Member
|
Looks like a good start, the exporting works nicely. Could you hide the import / export based on the user being logged in?
|
234c7e7 to
6f7fa47
Compare
Contributor
Author
|
The last commit should do the trick but I don't like much. It'd be better if resources could export the required role to access them, but I keep fighting the typesystem over objects. |
a25cb95 to
9662bf3
Compare
tmcgilchrist
approved these changes
Apr 22, 2022
2 tasks
tmcgilchrist
added a commit
to tmcgilchrist/opam-repository
that referenced
this pull request
Jun 2, 2022
…, current_github, current_git, current_examples, current_docker and current (0.6.1) CHANGES: Web UI: - UI restyle, embed files using ocaml-crunch. (@ewanmellor, @MisterDA, ocurrent/ocurrent#315) - Automatically refresh some pipeline pages. (@MisterDA, ocurrent/ocurrent#227) - Allow to import and export using CSV the log rules. (@MisterDA, ocurrent/ocurrent#327) - Log matcher takes the pattern with the highest score (@kit-ty-kate, ocurrent/ocurrent#335) API: - GitHub: Add pp_short for commit and fix url link for GH commits. (@tmcgilchrist, ocurrent/ocurrent#347) - GitHub: Fetch commit messages for commits on GitHub (@punchagan, ocurrent/ocurrent#337) - GitHub: Add Current_github.Api.cmdliner_opt. (@dra27, ocurrent/ocurrent#338) - GitHub: Add extra PR information to Ref.t (@tmcgilchrist @TheLortex, ocurrent/ocurrent#336) Plugins: - GitLab: support GitLab clone fork and fetch MR branch. (@MisterDA, ocurrent/ocurrent#346) - Git: Fix handling of git repositories with submodules. (@talex5, ocurrent/ocurrent#345) - GitLab: Fix ref filtering bug for GitLab (@tmcgilchrist, ocurrent/ocurrent#332) Other: - Add missing dependencies on Unix (@dra27, ocurrent/ocurrent#331)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to import (by a CSV file upload) and export rules (to a CSV
file) from the web UI. For now, uploading doesn't work as I'm not sure
how to correctly retreive the file data, and more importantly I can't
figure out why file file upload always errors with "Bad CSRF" (help
would be appreciated).
Sub-question: do we want to "atomically" import all rules, i.e. should
we validate the whole file before adding rules, or install rules but
retract installed rules if there's an error down the line, or just gather
errors as I've done?