Skip to content

refactor: Use pymysql to automatically escape#76

Closed
longbingljw wants to merge 17 commits into
oceanbase:mainfrom
longbingljw:escape
Closed

refactor: Use pymysql to automatically escape#76
longbingljw wants to merge 17 commits into
oceanbase:mainfrom
longbingljw:escape

Conversation

@longbingljw

@longbingljw longbingljw commented Dec 16, 2025

Copy link
Copy Markdown
Member

Summary

Use parameterized query and pymysql will automatically escape the parameters
close #62
fix #75

Solution Description

y1-l1n and others added 16 commits December 5, 2025 11:59
@y1-l1n
hybrid_search() interface suppport boost param
f383d46
@y1-l1n
hybrid_search() supports not_contains
030b382
@y1-l1n
hybrid_searh() supports $in $nin
e8521e8
@y1-l1n
enhance hybrid_search() interface:new builder
1d046fb
@y1-l1n
HybridSearch().rank() enhance
3d70d13
@y1-l1n
Merge pull request oceanbase#63 from y1-l1n/dev
7e42ee8 
provide HybridSearch class to enhance hybrid_search interface
@hnwyllmm
make execute private (oceanbase#65)
d5d0848 
<!--
Thank you for contributing to OceanBase! 
Please feel free to ping the maintainers for the review!
-->

## Summary
<!-- 
Please clearly and concisely describe the purpose of this pull request.
If this pull request resolves an issue, please link it via "close #xxx"
or "fix #xxx".
-->
close oceanbase#64 
make Client.execute a private method.
@hnwyllmm
Fix execute bug in client_base.py (oceanbase#67)
134705f 
Fix execute bug in client_base.py
@hnwyllmm
Support fulltext index parser configuration (oceanbase#68)
1ec851c 
<!--
Thank you for contributing to OceanBase! 
Please feel free to ping the maintainers for the review!
-->

## Summary
<!-- 
Please clearly and concisely describe the purpose of this pull request.
If this pull request resolves an issue, please link it via "close #xxx"
or "fix #xxx".
-->
close oceanbase#56

Support fulltext index parser configuration
fix: escape fix
3ec2ad7
test
e9921b5
fix
53a53ad
fix
b5a191c
hybrid_search escape
cacef15
Revert "test"
1ebe7a2 
This reverts commit e9921b5.
fix
257084e
@coderabbitai

coderabbitai Bot commented Dec 16, 2025

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@hnwyllmm

hnwyllmm commented Dec 16, 2025

Copy link
Copy Markdown
Member

Could you please create a new pull request to target develop branch?

@longbingljw

longbingljw commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

Could you please create a new pull request to target develop branch?

Seems like it will be some code conflicts.

@whhe

whhe commented Dec 16, 2025

Copy link
Copy Markdown
Member

I would prefer to use placeholders to set parameters rather than directly calling escape_string. https://pymysql.readthedocs.io/en/latest/modules/cursors.html#pymysql.cursors.Cursor.execute

@longbingljw

longbingljw commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

I would prefer to use placeholders to set parameters rather than directly calling escape_string. https://pymysql.readthedocs.io/en/latest/modules/cursors.html#pymysql.cursors.Cursor.execute

Thanks,I will check it.

@longbingljw

longbingljw commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

I would prefer to use placeholders to set parameters rather than directly calling escape_string. https://pymysql.readthedocs.io/en/latest/modules/cursors.html#pymysql.cursors.Cursor.execute

I looked into it, and the embedded version of pyseekdb doesn't support parameterized queries. It's possible that when the server-side component was added, using parameterized queries wasn't considered either.

@longbingljw

longbingljw commented Dec 16, 2025

Copy link
Copy Markdown
Member Author

New pr:#77
This pr will be closed.

@longbingljw longbingljw mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@longbingljw @hnwyllmm @whhe @y1-l1n