Fix execute bug in client_base.py#67
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where incorrect method calls were made throughout client_base.py. The code was calling self.execute() (which doesn't exist) instead of the correct self._execute() method that is defined in the BaseConnection abstract class and implemented in both client implementations.
Key Changes:
- Replaced all 13 occurrences of
self.execute()withself._execute()inclient_base.py - Added
developbranch to CI workflow triggers for both push and pull_request events
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/pyseekdb/client/client_base.py | Fixed all incorrect self.execute() calls to use self._execute() across collection management methods (create, get, delete, list, has) and collection operations (add, update, upsert) |
| .github/workflows/ci.yml | Added develop branch to CI triggers to enable automated testing on the development branch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix execute bug in client_base.py