make execute private#65
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the SQL execution method from public (execute) to private (_execute) across the codebase, following Python conventions for internal methods. The changes update the abstract base class and its two concrete implementations (embedded and remote server clients), along with documentation updates to remove public API examples.
- Renamed
BaseConnection.execute()toBaseConnection._execute()in the abstract base class - Updated all internal calls to
_execute()inRemoteServerClientandSeekdbEmbeddedClientimplementations - Removed public API example showing
client.execute()usage from README
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pyseekdb/client/base_connection.py | Renamed abstract method from execute to _execute; removed unused _Transaction class |
| src/pyseekdb/client/client_seekdb_server.py | Updated 4 method calls from self.execute() to self._execute() |
| src/pyseekdb/client/client_seekdb_embedded.py | Updated 4 method calls from self.execute() to self._execute(); cleaned up whitespace |
| README.md | Removed code example demonstrating public execute() method usage |
| src/pyseekdb/client/init.py | Removed trailing whitespace from comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
close #64
make Client.execute a private method.