Fix comments' placement (do not look at loc_stack)#923
Merged
gpetiot merged 1 commit intoocaml-ppx:masterfrom Jul 31, 2019
gpetiot:no-loc-stack
Merged
Fix comments' placement (do not look at loc_stack)#923gpetiot merged 1 commit intoocaml-ppx:masterfrom gpetiot:no-loc-stack
gpetiot merged 1 commit intoocaml-ppx:masterfrom
gpetiot:no-loc-stack
Conversation
Closed
Julow
approved these changes
Jul 31, 2019
Collaborator
Julow
left a comment
There was a problem hiding this comment.
This is fixing some bugs but add some.
| 2 | ||
| let _ = 2 (* a *) | ||
|
|
||
| (* b *) |
Collaborator
There was a problem hiding this comment.
This is wrong. The original code was:
let _ =
( (* a *) ( (* b *) 2 ))| let _ = 'a' | ||
|
|
||
| let _ = (* test *) "asd" | ||
| let _ = "asd" (* test *) |
Collaborator
There was a problem hiding this comment.
Should be on the left, was:
let _ = ((* test *)"asd" )| ({f; g} (* 3 *) as (* 4 *) x) | ||
| (* 5 *) | ||
| (* 6 *) = | ||
| ~x:(* 1 *) ((* 2 *) {f; g} (* 3 *) as (* 4 *) x (* 5 *)) (* 6 *) = |
Collaborator
There was a problem hiding this comment.
(* 1 *) is still wrong, it should be before ~x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #917, will be reverted with #921
Diff of test_branch: