Conversation
|
Last regression of test_branch that I didn't manage to fix yet (with let prop_init_formals_seed fooooooooooooooooooo =
let sigma_seed =
create_seed_vars (* formals already there plus new ones *) (prop.Prop.sigma @ sigma_new_formals)
in
fooooooooooooooooooooooooooIt is margin dependent, it is well formatted for 99 and 101 but fails for 100, I think the issue is due to the |
|
@hhugo I fixed the last regressions I think it's ready to be reviewed now. |
|
|
||
| class a = | ||
| (* A'' *) | ||
| let open (* A' *) A (* A *) in |
There was a problem hiding this comment.
I didn't manage to fix this one, nothing seems wrong in the code.
| open (* c *) struct | ||
| type t | ||
| end | ||
| (* d *) in |
There was a problem hiding this comment.
comment move inside.
There was a problem hiding this comment.
This is due to the new within/within heuristics, and I didn't manage to fix this without reverting to the state previous to this PR.
Julow
left a comment
There was a problem hiding this comment.
Looks like this is slowing down ocamlformat a lot !
Running dune clean; time dune runtest takes 9s on master and 1m30 with this PR.
|
I optimized a bit the changes made in Cmts.ml, but it can still be improved, any idea is welcomed. |
|
I believe I've fixed most of the performance issue. |
Julow
left a comment
There was a problem hiding this comment.
This PR is very big. Is there parts that could be moved to new PRs to make review easier ?
| type usert | ||
|
|
||
| type usert (* a user-defined value *) | ||
| (* a user-defined value *) |
There was a problem hiding this comment.
These 3 comments are not placed correctly, the original code is:
module type VALUE = sig
type value (* a Lua value *)
type state (* the state of a Lua interpreter *)
type usert (* a user-defined value *)
end;;
The diff in Translation_unit can be moved in a separate PR |
3b8e5fa to
c813fd7
Compare
|
Should revert #923 once it is merged. |
e3b0ef7 to
f32bbee
Compare
|
Fixed the conflicts but it is worse than before, more work needed to the attachment algorithm. |
|
What should we do with this PR ? |
|
Hopefully #1193 will fix everything this issue tries to fix. Something weird happened to this PR I can't push commits to it anymore. |
|
Should this be closed or converted to a draft? |
attempt to fix #917