CLI tests: use dune to run ocamlformat#1157
Merged
emillon merged 1 commit intoocaml-ppx:masterfrom Nov 22, 2019
Merged
Conversation
737dcf3 to
ab008d4
Compare
Collaborator
|
Why are test generators a bit heavy ? |
Collaborator
|
For me personally it is easier to maintain OCaml code than dune code but I don't have any other argument against writing rules manually, as long as we don't add new ones too often. |
ab008d4 to
e3dc941
Compare
Collaborator
Author
|
As discussed offline with @Julow, the main disadvantage of this approach is that adding new tests involve copy/pasting, so it's possible that we'll forget to add the runtest-diff part for one test someday. Two things can make this easier in the future:
|
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment. So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.
e3dc941 to
1e6cca2
Compare
bogdan2412
pushed a commit
to bogdan2412/ocamlformat
that referenced
this pull request
Mar 28, 2020
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment. So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(partial revert of #1126, as discussed in #1147)
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment.
So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.