Use an expect test for cli tests#1126
Merged
emillon merged 1 commit intoocaml-ppx:masterfrom Nov 5, 2019
Merged
Conversation
gpetiot
approved these changes
Nov 5, 2019
Collaborator
gpetiot
left a comment
There was a problem hiding this comment.
Looks good to me, and it will be easier to test every combination of options.
Collaborator
Author
|
We don't really need to test all the combinations though :) |
This removes the test generator and replaces it by a driver that runs ocamlformat. The output is compared by dune to `test_cli.expected` which handles promotion.
8705b98 to
a978303
Compare
Collaborator
Author
|
Thanks! |
emillon
added a commit
to emillon/ocamlformat
that referenced
this pull request
Nov 19, 2019
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment. So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.
emillon
added a commit
to emillon/ocamlformat
that referenced
this pull request
Nov 19, 2019
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment. So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.
emillon
added a commit
to emillon/ocamlformat
that referenced
this pull request
Nov 22, 2019
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment. So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.
emillon
added a commit
to emillon/ocamlformat
that referenced
this pull request
Nov 22, 2019
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment. So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.
emillon
added a commit
that referenced
this pull request
Nov 22, 2019
bogdan2412
pushed a commit
to bogdan2412/ocamlformat
that referenced
this pull request
Mar 28, 2020
This removes the test generator and replaces it by a driver that runs ocamlformat. The output is compared by dune to `test_cli.expected` which handles promotion.
bogdan2412
pushed a commit
to bogdan2412/ocamlformat
that referenced
this pull request
Mar 28, 2020
Test generators are a bit heavy, but running processes through ocaml is a bit limited when we want to set a working directory or environment. So, let's use a middle ground solution: run ocamlformat through dune, but write the rules by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the test generator and replaces it by a driver that runs ocamlformat. The output is compared by dune to
test_cli.expectedwhich handles promotion.This removes a generator and many small files while keeping the promotion-based workflow, so I think it's valuable. What do you think?