No longer remove source dir on reinstall#6550
Merged
kit-ty-kate merged 4 commits intoocaml:masterfrom Jun 18, 2025
Merged
Conversation
rjbou
commented
Jun 17, 2025
Merged
rjbou
commented
Jun 17, 2025
| @@ -1,4 +1,25 @@ | |||
|
|
|||
| (rule | |||
| (alias reftest-action-disk) | |||
Collaborator
Author
There was a problem hiding this comment.
If you find a better name for the test
59724c2 to
ad9728c
Compare
ad9728c to
cea3dd2
Compare
kit-ty-kate
approved these changes
Jun 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First noticed on #6539.
In #6436, removing build dir changes made the call to the function to clean packages artefacts no more called only for non pinned packages. This function was originally called when calling
opam clean, it is no more the case, it is safe to no longer remove sources directory of non pinned package in it.Fix #6554
Queued on