reftest: add test for opam repo ci reinstall workflow#6539
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Jun 18, 2025
Merged
reftest: add test for opam repo ci reinstall workflow#6539kit-ty-kate merged 1 commit intoocaml:masterfrom
kit-ty-kate merged 1 commit intoocaml:masterfrom
Conversation
kit-ty-kate
reviewed
Jun 10, 2025
tests/reftests/opam-repo-ci.test
Outdated
| - | ||
| Processing 1/7: [main.1: extract] | ||
| + tar "xfz" "${OPAMTMP}/archive.tgz" "-C" "${OPAMTMP}" | ||
| -> retrieved main.1 (file://${BASEDIR}/archive.tgz) |
Member
There was a problem hiding this comment.
this line is absent from the original reported issue, which might mean that the archive/directory was retrieved from a different location
Member
There was a problem hiding this comment.
I was able to reproduce the issue with the following dockerfile:
FROM ocaml/opam
RUN sudo ln -f /usr/bin/opam-dev /usr/bin/opam
RUN opam init --reinit -ni
RUN opam pin add -k version -yn dune.3.18.0 3.18.0
RUN opam install dune.3.18.0
RUN rm -rf /home/opam/.opam/download-cache/sha512
RUN rm -rf /home/opam/.opam/download-cache/sha256/b7
RUN opam reinstall --with-test dune.3.18.0
Member
|
I was able to reproduce the original issue: The first |
Member
|
After some bisecting i found the culprit: #6436 The issue is that reinstalls are decoupled into remove and install actions. In the case of a real reinstall we of course want to remove all the artefacts, but if it's a reinstall we actually want to keep them. |
2b4e369 to
f3af917
Compare
2 tasks
f3af917 to
3c4d188
Compare
3c4d188 to
67cf68c
Compare
Merged
64279c1 to
9bc9629
Compare
9bc9629 to
06c543e
Compare
06c543e to
068452f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for ocurrent/opam-repo-ci#441
queued on